meson: add pthreads option - #268
Closed
ffontaine wants to merge 1 commit into
Closed
Conversation
Allow the user to disable pthreads Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Owner
|
Why? What kind of platform is this, that does not have pthread? Care to elaborate what is the goal of adding a build time option that I am going to support? |
Author
Owner
|
I very much doubt anybody will ever use graphene on microcontrollers, considering the nature of the project; unless there are microcontrollers with vector instructions somewhere…
I think it's more appropriate to add a dependency. I definitely do not test Graphene without a platform threading implementation, so I can't ensure it'll ever work. Thanks for your contribution, in any case. |
arnout
pushed a commit
to buildroot/buildroot
that referenced
this pull request
May 29, 2026
Building without threads support fails: /home/autobuild/autobuild/instance-9/output-1/host/aarch64-buildroot-linux-uclibc/sysroot/usr/include/features.h:220:5: warning: #warning requested reentrant code, but thread support was disabled [-Wcpp] Added dependency to threads as suggested by upstream: ebassi/graphene#268 (comment) Fixes: http://autobuild.buildroot.org/results/9b3/9b357b1ef2eccd3110d0ecaaff1ae4883dff9280 Signed-off-by: Francois Perrad <francois.perrad@gadz.org> [Bernd: - added comment to libgtk4 - added upstream response to our bug report] Signed-off-by: Bernd Kuhls <bernd@kuhls.net> Signed-off-by: Arnout Vandecappelle <arnout@rnout.be>
arnout
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Jun 5, 2026
Building without threads support fails: /home/autobuild/autobuild/instance-9/output-1/host/aarch64-buildroot-linux-uclibc/sysroot/usr/include/features.h:220:5: warning: #warning requested reentrant code, but thread support was disabled [-Wcpp] Added dependency to threads as suggested by upstream: ebassi/graphene#268 (comment) Fixes: http://autobuild.buildroot.org/results/9b3/9b357b1ef2eccd3110d0ecaaff1ae4883dff9280 Signed-off-by: Francois Perrad <francois.perrad@gadz.org> [Bernd: - added comment to libgtk4 - added upstream response to our bug report] Signed-off-by: Bernd Kuhls <bernd@kuhls.net> Signed-off-by: Arnout Vandecappelle <arnout@rnout.be> (cherry picked from commit 07f872b) Signed-off-by: Thomas Perale <thomas.perale@mind.be>
arnout
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Jun 5, 2026
Building without threads support fails: /home/autobuild/autobuild/instance-9/output-1/host/aarch64-buildroot-linux-uclibc/sysroot/usr/include/features.h:220:5: warning: #warning requested reentrant code, but thread support was disabled [-Wcpp] Added dependency to threads as suggested by upstream: ebassi/graphene#268 (comment) Fixes: http://autobuild.buildroot.org/results/9b3/9b357b1ef2eccd3110d0ecaaff1ae4883dff9280 Signed-off-by: Francois Perrad <francois.perrad@gadz.org> [Bernd: - added comment to libgtk4 - added upstream response to our bug report] Signed-off-by: Bernd Kuhls <bernd@kuhls.net> Signed-off-by: Arnout Vandecappelle <arnout@rnout.be> (cherry picked from commit 07f872b) Signed-off-by: Thomas Perale <thomas.perale@mind.be>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the user to disable pthreads