Skip to content

fix: clarify two misleading script messages#856

Merged
strawgate merged 2 commits intomainfrom
fix/issue-855-misleading-messages-deddbe92fc3121ed
Apr 14, 2026
Merged

fix: clarify two misleading script messages#856
strawgate merged 2 commits intomainfrom
fix/issue-855-misleading-messages-deddbe92fc3121ed

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Apr 1, 2026

Summary

This PR resolves #855 by updating two user-facing script messages that could mislead readers.

Changes

  • scripts/trigger-ci-workflows.sh
    • Changed summary text from "Dispatched ..." to "Attempted to dispatch ..." so output no longer implies every dispatch succeeded when per-workflow failures may have occurred.
  • claude-workflows/pr-review/scripts/pr-diff.sh
    • Clarified the single-file error message to indicate either the file is not in the PR diff or patch data is unavailable (binary/too large).

Validation

  • make lint
  • make test ✅ (run with UV_CACHE_DIR=/tmp/gh-aw/agent/uv-cache and uv from a temporary virtualenv due runner environment constraints)

Closes #855.


What is this? | From workflow: Trigger Text Auditor

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

github-actions bot and others added 2 commits April 1, 2026 13:58
- use 'Attempted to dispatch' in trigger-ci-workflows summary

- clarify pr-diff error when patch is unavailable

Closes #855

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions bot added the small_boom Small PR blast radius; usually low human-review need label Apr 1, 2026
@strawgate strawgate marked this pull request as ready for review April 14, 2026 17:14
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8f207ff9-eb94-4c2b-a9c2-37a23b98dd17

📥 Commits

Reviewing files that changed from the base of the PR and between e2e9566 and b276491.

📒 Files selected for processing (2)
  • claude-workflows/pr-review/scripts/pr-diff.sh
  • scripts/trigger-ci-workflows.sh

📝 Walkthrough

Walkthrough

Two user-facing error/status messages were updated in bash scripts. The first modifies the error message in claude-workflows/pr-review/scripts/pr-diff.sh when patch data is unavailable, now indicating the file may be missing from the PR diff or patch data is unavailable due to binary/size constraints. The second changes the final status line in scripts/trigger-ci-workflows.sh from "Dispatched" to "Attempted" to better reflect cases where workflow dispatch failures occurred. Both changes are single-line string modifications with no alterations to control flow, exit codes, or logic.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The pull request addresses both objectives from issue #855: updating dispatch summary wording to 'Attempted' and clarifying the pr-diff error message to indicate patch data unavailability.
Out of Scope Changes check ✅ Passed Changes are limited to two error message updates in the specified files with no extraneous modifications.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/issue-855-misleading-messages-deddbe92fc3121ed
  • 🛠️ Update Documentation: Commit on current branch
  • 🛠️ Update Documentation: Create PR

Comment @coderabbitai help to get the list of available commands and usage tips.

@strawgate strawgate merged commit ed04d23 into main Apr 14, 2026
27 checks passed
@strawgate strawgate deleted the fix/issue-855-misleading-messages-deddbe92fc3121ed branch April 14, 2026 17:17
strawgate added a commit that referenced this pull request Apr 14, 2026
Recompiles lock files to reflect merged changes from PRs:
#903, #901, #890, #885, #881, #866, #856, #814, #715

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

small_boom Small PR blast radius; usually low human-review need

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[text-auditor] Fix two misleading PR/dispatch user-facing script messages

1 participant