Conversation
Ignore catalog links inside HTML comments before extracting workflow slugs, so temporarily commented entries do not fail nav coverage checks. Adds regression tests for slug extraction and main() success behavior with commented links. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe changes modify the catalog slug extraction logic in 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
gh-agent-workflows/<slug>.mdlinks (including query/anchor variants).extract_catalog_slugsandmain()so commented catalog links are ignored.Why
scripts/check-nav-catalog.pypreviously treated links inside HTML comments (<!-- ... -->) as active catalog entries. That created deterministic false CI failures when intentionally commented-out links were not present in nav.Validation
python -m pytest tests/test_check_nav_catalog.py -vpython scripts/check-nav-catalog.pyCloses #900.
The body of this PR is automatically managed by the Trigger Update PR Body workflow.