pipeline: remove redundant Paths from Settings and Supporter - #49841
Conversation
🤖 GitHub commentsJust comment with:
|
ce06766 to
6b92ca0
Compare
6b92ca0 to
cd05c9f
Compare
cd05c9f to
cc35ae1
Compare
The Pipeline already has beatInfo which contains Paths. Remove the separate paths field from Pipeline and Settings, and remove the paths parameter from the processing.Supporter.Create interface. The builder now uses info.Paths directly when calling SetPaths on processors.
cc35ae1 to
b662742
Compare
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
This comment has been minimized.
This comment has been minimized.
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe change removes the 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This comment has been minimized.
This comment has been minimized.
After the merge with main the local beatPaths variables in dockerlogbeat/libbeattools.go and stress/run.go were left dangling once Settings.Paths was removed (causing a go vet break in dockerlogbeat). Address the review feedback by setting info.Paths on beat.Info instead, so paths flow through Info as the rest of this PR does.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
TL;DRAll three failing Buildkite jobs are failing in cross-build Remediation
Investigation detailsRoot CauseThis is a configuration/infrastructure failure, not a beat-specific code regression:
Relevant build path in repo:
If the checkout change in this PR alters where Git metadata lives (e.g. Evidence
VerificationNot run locally in this environment; diagnosis is based on the failing job logs and the cross-build invocation path. Follow-upAfter fixing Git metadata visibility (or applying temporary Note 🔒 Integrity filter blocked 2 itemsThe following items were blocked because they don't meet the GitHub integrity level.
To allow these resources, lower tools:
github:
min-integrity: approved # merged | approved | unapproved | noneWhat is this? | From workflow: PR Buildkite Detective Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
Guards against the nil-Paths regression that broke disk-queue output configuration on dockerlogbeat after the outputs refactor. Closes elastic#50450
|
@Mergifyio backport 8.19 9.3 9.4 |
✅ Backports have been createdDetails
Cherry-pick of 3712f9b has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Cherry-pick of 3712f9b has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Cherry-pick of 3712f9b has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
…s and Supporter (#50615) * pipeline: remove redundant Paths from Settings and Supporter (#49841) pipeline: remove redundant Paths from Settings and Supporter Pipeline stored both beatInfo and a separate *paths.Path, and threaded it through the processing.Supporter.Create interface just to call SetPaths on processors. Now that Info carries Paths, remove the field from Pipeline and Settings, drop the parameter from Supporter.Create, and let the builder read paths from info.Paths. (cherry picked from commit 3712f9b) # Conflicts: # libbeat/publisher/pipeline/pipeline.go * fix backport: drop NewForReceiver and otel controller leftovers NewForReceiver and newOTelOutputController/newProcessOutputController do not exist on this branch; they were introduced on main by #50075/#50143 which have not been backported. Mergify left unresolved conflict markers around an attempt to bring them in. Resolve by keeping the HEAD side (existing newOutputController flow) while preserving the intended PR change of using beat.Paths in queueFactoryForUserConfig. --------- Co-authored-by: Orestis Floros <orestis.floros@elastic.co>
… and Supporter (#50616) * pipeline: remove redundant Paths from Settings and Supporter (#49841) pipeline: remove redundant Paths from Settings and Supporter Pipeline stored both beatInfo and a separate *paths.Path, and threaded it through the processing.Supporter.Create interface just to call SetPaths on processors. Now that Info carries Paths, remove the field from Pipeline and Settings, drop the parameter from Supporter.Create, and let the builder read paths from info.Paths. (cherry picked from commit 3712f9b) # Conflicts: # libbeat/publisher/pipeline/pipeline.go * fix backport: drop NewForReceiver and otel controller leftovers NewForReceiver and newOTelOutputController/newProcessOutputController do not exist on this branch; they were introduced on main by #50075/#50143 which have not been backported. Mergify left unresolved conflict markers around an attempt to bring them in. Resolve by keeping the HEAD side (existing newOutputController flow) while preserving the intended PR change of using beat.Paths in queueFactoryForUserConfig. --------- Co-authored-by: Orestis Floros <orestis.floros@elastic.co>
… and Supporter (#50617) * pipeline: remove redundant Paths from Settings and Supporter (#49841) pipeline: remove redundant Paths from Settings and Supporter Pipeline stored both beatInfo and a separate *paths.Path, and threaded it through the processing.Supporter.Create interface just to call SetPaths on processors. Now that Info carries Paths, remove the field from Pipeline and Settings, drop the parameter from Supporter.Create, and let the builder read paths from info.Paths. (cherry picked from commit 3712f9b) # Conflicts: # libbeat/publisher/pipeline/pipeline.go * fix backport: drop NewForReceiver leftover from conflict resolution NewForReceiver does not exist on this branch; it was introduced on main by #50075/#50143 which have not been backported. Mergify left unresolved conflict markers around an attempt to bring it in. Resolve by keeping the HEAD side and removing the function and the markers so the package compiles. --------- Co-authored-by: Orestis Floros <orestis.floros@elastic.co>
Proposed commit message
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added an entry in./changelog/fragmentsusing the changelog tool.Disruptive User Impact
None. Internal API change only.
How to test this PR locally
Related issues
Beat.Info#49803