Remove SOCKET_WEBRTC socket backend and dependencies#27367
Open
sbc100 wants to merge 1 commit into
Open
Conversation
Remove `-sSOCKET_WEBRTC` setting along with its vendored third-party dependencies `third_party/socket.io.js` (Socket.IO client v0.9.11) and `third_party/wrtcp.js` (experimental WebRTC P2P broker from 2012). `SOCKET_WEBRTC` has long been disabled by default, marked as untested and potentially broken in `src/settings.js`, and has no test coverage in the test suite. Furthermore, the underlying libraries depend on obsolete protocol versions, vendor-prefixed WebRTC constructors, and a hardcoded STUN server IP address. `-sSOCKET_WEBRTC=0` is moved to `LEGACY_SETTINGS` for backwards compatibility, while passing `-sSOCKET_WEBRTC=1` will now produce a clear error.
kripken
approved these changes
Jul 17, 2026
kripken
left a comment
kripken
left a comment
Member
There was a problem hiding this comment.
lgtm, though should we wait to see if users are using it?
Collaborator
Author
|
Yes lets see if anyone responds to https://groups.google.com/g/emscripten-discuss/c/cCHo6tiLhL8. Also, I forgot to follow all the steps in https://github.com/emscripten-core/emscripten/blob/main/docs/process.md#deprecating-settings-and-features. Will do that.. |
sbc100
added a commit
that referenced
this pull request
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
-sSOCKET_WEBRTCsetting along with its vendored third-party dependenciesthird_party/socket.io.js(Socket.IO client v0.9.11) andthird_party/wrtcp.js(experimental WebRTC P2P broker from 2012).SOCKET_WEBRTChas long been marked as untested and potentially broken insrc/settings.js, and has no test coverage in the test suite. Furthermore, the underlying libraries depend on obsolete protocol versions, vendor-prefixed WebRTC constructors, and a hardcoded STUN server IP address.-sSOCKET_WEBRTC=0is moved toLEGACY_SETTINGSfor backwards compatibility, while passing-sSOCKET_WEBRTC=1will now produce a clear error.Fixes: #27366