Skip to content

Fix ArgoFloat configuration parameter availability checking inconsistency - #644

Merged
gmaze merged 39 commits into
masterfrom
643-argofloat-configuration-parameter-availability-check-is-not-consistent
Jul 15, 2026
Merged

Fix ArgoFloat configuration parameter availability checking inconsistency#644
gmaze merged 39 commits into
masterfrom
643-argofloat-configuration-parameter-availability-check-is-not-consistent

Conversation

@gmaze

@gmaze gmaze commented Jun 25, 2026

Copy link
Copy Markdown
Member

Closes #643

gmaze added 30 commits February 17, 2026 16:51
- deprec lsprofiles
- update describe_profiles
- new ls_profiles_for
- new ls_profiles
- new open_profile
- fix bug whereby the default ascending direction was not set
- refactor toward: open_profile and open_profiles methods
- more private place holder for perf.
- better docstrings
update facade docstring
- improve typing
- new lsp() as a profiles counter part to ls()
- change column names in describe_profiles
- fix bug whereby argosplitpath could not handle path from the auxiliary folder
- New CYCLE_NUMBERS attribute
- fix bug whereby ls_profiles() would not work for floats with cycle numbers not identical from the euroargofleet API and the netcdf files, this would lead to a wrong N_CYCLES attributes
- N_CYCLES now depends on CYCLE_NUMBERS
- CYCLE_NUMBERS is determined on the fly by looking at the GDAC folder 'profiles' content, not from API or netcdf content
- clean up 'open_profiles'
- this is better english
- this is more coherent with ls_profiles
- now include coverage for new profiles-related features
long due minimal doc for config and launchconfig
gmaze added 6 commits June 25, 2026 14:24
fix docstrnigs
refactoring of internal place holders (more explicit names)
I'm trying to make it as simple as simple for users, by limiting the list of methods available on the facade.

- af.ls > af._ls
- af.lsp > af._lsp
- af._ls > af.__ls
- af. ls_profiles_for > af. _ls_profiles_for
- af. describe_profiles > af. profiles_to_dataframe

Signed-off-by: Guillaume Maze <gmaze@ifremer.fr>
Signed-off-by: Guillaume Maze <gmaze@ifremer.fr>
Signed-off-by: Guillaume Maze <gmaze@ifremer.fr>
Signed-off-by: Guillaume Maze <gmaze@ifremer.fr>
@gmaze gmaze linked an issue Jun 25, 2026 that may be closed by this pull request
@gmaze gmaze moved this from Queued to In Progress in Argopy Management Dashboard Jun 25, 2026
@gmaze gmaze added invalid This doesn't seem right next-release Strongly needed for the next release labels Jun 25, 2026
gmaze added 3 commits June 25, 2026 17:01
Signed-off-by: Guillaume Maze <gmaze@ifremer.fr>
…lability-check-is-not-consistent

Signed-off-by: Guillaume Maze <gmaze@ifremer.fr>
@gmaze
gmaze merged commit 9abb633 into master Jul 15, 2026
26 of 28 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Argopy Management Dashboard Jul 15, 2026
@gmaze
gmaze deleted the 643-argofloat-configuration-parameter-availability-check-is-not-consistent branch July 15, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid This doesn't seem right next-release Strongly needed for the next release

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

ArgoFloat configuration parameter availability check is not consistent

1 participant