Skip to content

Fix "'RCTBlobPlugins.h' file not found" on iOS#29684

Closed
tido64 wants to merge 1 commit into
facebook:masterfrom
tido64:patch-1
Closed

Fix "'RCTBlobPlugins.h' file not found" on iOS#29684
tido64 wants to merge 1 commit into
facebook:masterfrom
tido64:patch-1

Conversation

@tido64
Copy link
Copy Markdown
Collaborator

@tido64 tido64 commented Aug 18, 2020

Summary

Fixes iOS builds failing with the following error in certain setups:

/~/Pods/React-RCTBlob/Libraries/Blob/RCTBlobPlugins.mm:14:9: fatal error: 'RCTBlobPlugins.h' file not found
#import "RCTBlobPlugins.h"
        ^~~~~~~~~~~~~~~~~~
1 error generated.

Changelog

[iOS] [Fixed] - "'RCTBlobPlugins.h' file not found" when building iOS

Test Plan

  • Existing builds should not fail
  • Tested this change internally where we are seeing this build failure

cc @hramos

Fixes iOS builds failing with the following error:
```
/~/Pods/React-RCTBlob/Libraries/Blob/RCTBlobPlugins.mm:14:9: fatal error: 'RCTBlobPlugins.h' file not found
#import "RCTBlobPlugins.h"
        ^~~~~~~~~~~~~~~~~~
1 error generated.
```
@react-native-bot react-native-bot added Bug Platform: iOS iOS applications. labels Aug 18, 2020
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner labels Aug 18, 2020
@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,003,058 0
android hermes armeabi-v7a 6,666,661 0
android hermes x86 7,423,383 0
android hermes x86_64 7,314,273 0
android jsc arm64-v8a 9,162,926 0
android jsc armeabi-v7a 8,818,650 0
android jsc x86 9,011,324 0
android jsc x86_64 9,588,414 0

Base commit: eecb930

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: eecb930

@tido64 tido64 requested a review from RSNara August 19, 2020 09:43
Copy link
Copy Markdown
Contributor

@alloy alloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this is good 👍

/cc @appden

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@appden has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @tido64 in aaeffdb.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Sep 8, 2020
@tido64 tido64 deleted the patch-1 branch September 8, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Microsoft Partner: Microsoft Partner Platform: iOS iOS applications.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants