BridgelessUIManager: Improve error message for getViewManagerConfig()#41998
Closed
RSNara wants to merge 3 commits into
Closed
BridgelessUIManager: Improve error message for getViewManagerConfig()#41998RSNara wants to merge 3 commits into
RSNara wants to merge 3 commits into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52002909 |
RSNara
force-pushed
the
export-D52002909
branch
from
be75e24 to
6671ab8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52002909 |
RSNara
force-pushed
the
export-D52002909
branch
from
6671ab8 to
de3c431
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52002909 |
RSNara
force-pushed
the
export-D52002909
branch
2 times, most recently
from
6756b86 to
8db0c17
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52002909 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52002909 |
RSNara
force-pushed
the
export-D52002909
branch
from
8db0c17 to
a09e4e2
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52002909 |
RSNara
force-pushed
the
export-D52002909
branch
from
a09e4e2 to
65ff3fc
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52002909 |
RSNara
force-pushed
the
export-D52002909
branch
from
65ff3fc to
8f6c474
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52002909 |
RSNara
force-pushed
the
export-D52002909
branch
from
8f6c474 to
4fa285d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52002909 |
RSNara
force-pushed
the
export-D52002909
branch
from
4fa285d to
af56316
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52002909 |
RSNara
force-pushed
the
export-D52002909
branch
from
af56316 to
c115773
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52002909 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52002909 |
RSNara
force-pushed
the
export-D52002909
branch
from
c115773 to
617dbc8
Compare
…Manager (facebook#41997) Summary: Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876
…dren, manageChildren (facebook#42067) Summary: These methods should not be implemented in the new architecture. The **only** code that called these UIManagerModule methods was the paper renderer. And the New Architecture should instead use the Fabric renderer. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52345416
…facebook#41998) Summary: Now the error message propts people to turn on the interop layer. And, it adds more details to the suggestion to use hasViewManager(viewManagerName). Changelog: [Internal] Reviewed By: cortinico Differential Revision: D52002909
RSNara
force-pushed
the
export-D52002909
branch
from
617dbc8 to
bbaceae
Compare
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 10, 2024
…erConfig() (facebook#41998) Summary: Now the error message propts people to turn on the interop layer. And, it adds more details to the suggestion to use hasViewManager(viewManagerName). Changelog: [Internal] Reviewed By: cortinico Differential Revision: D52002909
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52002909 |
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 10, 2024
…erConfig() (facebook#41998) Summary: Now the error message propts people to turn on the interop layer. And, it adds more details to the suggestion to use hasViewManager(viewManagerName). Changelog: [Internal] Reviewed By: cortinico Differential Revision: D52002909
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 10, 2024
…erConfig() (facebook#41998) Summary: Now the error message propts people to turn on the interop layer. And, it adds more details to the suggestion to use hasViewManager(viewManagerName). Changelog: [Internal] Reviewed By: cortinico Differential Revision: D52002909
Contributor
|
This pull request has been merged in 9670bde. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Now the error message propts people to turn on the interop layer.
And, it adds more details to the suggestion to use hasViewManager(viewManagerName).
Changelog: [Internal]
Reviewed By: cortinico
Differential Revision: D52002909