This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Distinguish between condition and log value in breakpoints - #7749
Merged
jasonLaster merged 2 commits intoJan 21, 2019
Conversation
bomsy
reviewed
Jan 18, 2019
| const sourceThreadClient = sourceThreads[bpClient.source.actor]; | ||
| return bpClient | ||
| .setCondition(sourceThreadClient, condition, noSliding) | ||
| .setCondition(sourceThreadClient, transformOptionsToCondition(options)) |
Contributor
There was a problem hiding this comment.
should we keep the noSliding argument?
Contributor
Author
There was a problem hiding this comment.
I removed this because BreakpointClient.prototype.setCondition doesn't actually take a third noSliding argument. It also ignores the thread client argument, which is tidied up by the patch in bug 1520972.
…te into a BreakpointOptions object.
jasonLaster
force-pushed
the
breakpoint-options
branch
from
January 18, 2019 18:07
d244892 to
8b7e8b2
Compare
jasonLaster
approved these changes
Jan 21, 2019
jasonLaster
pushed a commit
that referenced
this pull request
Jan 23, 2019
* Distinguish between condition and log value in breakpoints, consolidate into a BreakpointOptions object. * Fix some test failures.
jasonLaster
pushed a commit
that referenced
this pull request
Jan 28, 2019
* Distinguish between condition and log value in breakpoints, consolidate into a BreakpointOptions object. * Fix some test failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes