Fix timelineSettingsHiddenTracks in High Contrast Mode. #5250
Conversation
nchevobbe
force-pushed
the
hcm-track-selection-button
branch
from
e897232 to
d880400
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5250 +/- ##
==========================================
- Coverage 88.62% 88.61% -0.02%
==========================================
Files 308 308
Lines 28121 28125 +4
Branches 7620 7621 +1
==========================================
Hits 24923 24923
- Misses 2984 2987 +3
- Partials 214 215 +1 ☔ View full report in Codecov by Sentry. |
canova
left a comment
canova
left a comment
There was a problem hiding this comment.
Thanks for the PR! Looks good to me.
I noticed that the background of the :active state when we press down looks like when it's not hovered or pressed. Is it intentional?
I'm happy to land this one as it's clearly an improvement. But wanted to double check that too.
I must have forgot. https://www.figma.com/design/VHRA9hZ54oJqKKJwPd6FWa/High-Contrast-Mode?node-id=9-458&node-type=canvas&t=xEZgU93GaKACUFVp-0 says that we should have a |
Make it look like a HCM button and actually display the arrow.
nchevobbe
force-pushed
the
hcm-track-selection-button
branch
from
d7c13d8 to
ea960bc
Compare
|
(fixed lint issue and checked manually that the active style is indeed applied) |
Updates: [Nicolas Chevobbe] Adapt Keyboard shortcut dialog in High Contrast Mode. (#5245) [Nicolas Chevobbe] Fix sidebar-toggle in High Contrast Mode. (#5246) [Nicolas Chevobbe] Fix timeline selection overlay time / hover line in High Contrast Mode (#5247) [Zac Spitzer] fix broken link for processed profile format (#5267) [Greg Tatum] Update the memory allocation docs and add DHAT docs (#5270) [Markus Stange] Simplify some code related to thread CPU deltas (#5265) [Greg Tatum] Update dhat convertor to work better with valgrind (#5269) [Markus Stange] Rename UniqueStringArray to StringTable. (#5283) [Markus Stange] Use snapshot testing in the symbolicator CLI test. (#5284) [Markus Stange] Fix two confused upgraders which didn't expect to be run on the serialized format. (#5285) [Nicolas Chevobbe] Fix timelineSettingsHiddenTracks in High Contrast Mode. (#5250) [Julien Wajsberg] Fix some test and non-test warnings (#5294) [Nisarg Jhaveri] Support importing simpleperf trace files from Android Studio (#5212) [Sean Kim] Add HTTP response status code in the profiler network tab (#5297) [Markus Stange] Change StringTable API a bit. (#5286) [Markus Stange] Correctly declare imported simpleperf trace profiles to be of the current version. (#5312) [Markus Stange] Two small changes (#5313) [Nazım Can Altınova] Show sample tooltips on sample graph hover (#5298) Also thanks to our localizers: en-CA: chutten es-CL: ravmn es-CL: ravmn fr: Théo Chevalier ia: Melo46 ia: Melo46 sv-SE: Andreas Pettersson uk: Lobodzets zh-TW: Olvcpr423
2 participants
Make it look like a HCM button and actually display the arrow.