Fix some test and non-test warnings #5294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5294 +/- ##
==========================================
- Coverage 88.61% 88.61% -0.01%
==========================================
Files 308 308
Lines 28125 28122 -3
Branches 7621 7620 -1
==========================================
- Hits 24923 24920 -3
Misses 2987 2987
Partials 215 215 ☔ View full report in Codecov by Sentry. |
canova
approved these changes
Jan 8, 2025
Member
canova
left a comment
canova
left a comment
There was a problem hiding this comment.
Thanks for fixing the warnings! Looks good to me, but let me know what you think about the comment below. It's fine by me if you choose to go with the current approach too.
Comment on lines
134
to
146
| // As of React 18, If the action dispatch isn't delayed, the component will | ||
| // get rerendered with the redux changes before the react state changes are | ||
| // applied. As a result CurrentProfileUploadedInformationLoader could reset | ||
| // the profile information faster than this metaInfoPanelState was applied, | ||
| // and we were getting an error in _renderMetaInfoButton. | ||
| // Using requestAnimationFrame ensures that this component's state | ||
| // is properly applied before changing the redux state. Note that if we were | ||
| // using a function component, we could use useLayoutEffect instead. | ||
| // Note that this might not be necessary in future versions of React or | ||
| // React-Redux, so be sure to revisit this choice in the future. | ||
| requestAnimationFrame(() => { | ||
| this.props.profileRemotelyDeleted(); | ||
| }); |
Member
There was a problem hiding this comment.
Hm this is a bit hacky, but if it works it's okay for me I guess. Do we always know for sure that requestAnimationFrame will be enough for it to update the state?
Another solution might be to have a componentDidUpdate that checks if the metaInfoPanelState state has changed, and calls profileRemotelyDeleted only if it's changed.
julienw
force-pushed
the
fix-some-test-warnings
branch
from
48da62f to
61f1010
Compare
Contributor
Author
|
Hey @canova , I updated the code like we discussed, this looks better to me, thanks for the feedback! |
canova
approved these changes
Jan 10, 2025
Member
canova
left a comment
canova
left a comment
There was a problem hiding this comment.
Looks good to me! Also tested it and it works well, thanks!
julienw
added a commit
that referenced
this pull request
Jan 15, 2025
Updates: [Nicolas Chevobbe] Adapt Keyboard shortcut dialog in High Contrast Mode. (#5245) [Nicolas Chevobbe] Fix sidebar-toggle in High Contrast Mode. (#5246) [Nicolas Chevobbe] Fix timeline selection overlay time / hover line in High Contrast Mode (#5247) [Zac Spitzer] fix broken link for processed profile format (#5267) [Greg Tatum] Update the memory allocation docs and add DHAT docs (#5270) [Markus Stange] Simplify some code related to thread CPU deltas (#5265) [Greg Tatum] Update dhat convertor to work better with valgrind (#5269) [Markus Stange] Rename UniqueStringArray to StringTable. (#5283) [Markus Stange] Use snapshot testing in the symbolicator CLI test. (#5284) [Markus Stange] Fix two confused upgraders which didn't expect to be run on the serialized format. (#5285) [Nicolas Chevobbe] Fix timelineSettingsHiddenTracks in High Contrast Mode. (#5250) [Julien Wajsberg] Fix some test and non-test warnings (#5294) [Nisarg Jhaveri] Support importing simpleperf trace files from Android Studio (#5212) [Sean Kim] Add HTTP response status code in the profiler network tab (#5297) [Markus Stange] Change StringTable API a bit. (#5286) [Markus Stange] Correctly declare imported simpleperf trace profiles to be of the current version. (#5312) [Markus Stange] Two small changes (#5313) [Nazım Can Altınova] Show sample tooltips on sample graph hover (#5298) Also thanks to our localizers: en-CA: chutten es-CL: ravmn es-CL: ravmn fr: Théo Chevalier ia: Melo46 ia: Melo46 sv-SE: Andreas Pettersson uk: Lobodzets zh-TW: Olvcpr423
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes 2 warnings:
button.clickinstead offireEvent.click. The former isn't wrapped byactwhile the latter is.