Deploy January 15, 2025 #5318
Merged
Deploy January 15, 2025 #5318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Melo46 <melo@carmu.com>
Co-authored-by: Andreas Pettersson <amvpet@gmail.com>
Make sure the dialog has a border, that kbd elements have a distinct style and that the close button follows the Firefox HCM guidelines. Co-authored-by: Nazım Can Altınova <canaltinova@gmail.com>
Make sure the arrow is visible, and fix the hover style Co-authored-by: Nazım Can Altınova <canaltinova@gmail.com>
#5247) Co-authored-by: Nazım Can Altınova <canaltinova@gmail.com>
…iler Co-authored-by: Olvcpr423 <oliverchan86@outlook.com>
Co-authored-by: ravmn <ravmn@ravmn.cl>
Co-authored-by: Melo46 <melo@carmu.com>
…iler Co-authored-by: chutten <chutten@mozilla.com>
Make it look like a HCM button and actually display the arrow.
Co-authored-by: Lobodzets <Lobodzets@meta.ua>
Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.7 to 3.3.8. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.3.7...3.3.8)
Co-authored-by: Théo Chevalier <theochevalier@pm.me>
Co-authored-by: ravmn <ravmn@ravmn.cl>
Fix #5203. Attempt to add importer for simpleperf trace files. These can be generated using the `simpleperf report-sample` command or using Profiler UI in Android Studio. Here is the file format details: https://cs.android.com/android/platform/superproject/main/+/main:system/extras/simpleperf/cmd_report_sample.proto
This avoids copies of the underlying array. It also provides a new "constructor" (StringTable.withBackingArray) which avoids recreating the map when we need a StringTable for the same array in different places.
This avoids copies of the underlying array. It also provides a new "constructor" (StringTable.withBackingArray) which avoids recreating the map when we need a StringTable for the same array in different places.
…rent version. (#5312) This importer uses the Profile type, so it must be maintained to comply with the types of the latest version. But if the self-declared version is set to 50, it will go through the upgraders, which will not work if the profile is already using the current version.
This saves one level of indentation and feels more straightforward to me these days.
Two small changes in preparation for #5287. No changes in behavior.
…graph Previously we were always returning the closest sample to the mouse hover/click location. Which was okay when we were clicking to select the boxes before. But now we are also showing tooltips on hover which can be misleading if they were shown when we are not hovering over them. So to make this experience less confusing, this commit changes the behavior to only select or hover a specific sample when the mouse is actually on top of the sample box that we draw.
Previously we were using the exact same algorithm as the activity graph. Activity graph tests get the value in between this and the next same time. But for these tests, we actually want the exact sample time.
Updated locales: en-CA, es-CL, fr, ia, sv-SE, uk, zh-TW
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates:
[Nicolas Chevobbe] Adapt Keyboard shortcut dialog in High Contrast Mode. (#5245)
[Nicolas Chevobbe] Fix sidebar-toggle in High Contrast Mode. (#5246)
[Nicolas Chevobbe] Fix timeline selection overlay time / hover line in High Contrast Mode (#5247)
[Zac Spitzer] fix broken link for processed profile format (#5267)
[Greg Tatum] Update the memory allocation docs and add DHAT docs (#5270)
[Markus Stange] Simplify some code related to thread CPU deltas (#5265)
[Greg Tatum] Update dhat convertor to work better with valgrind (#5269)
[Markus Stange] Rename UniqueStringArray to StringTable. (#5283)
[Markus Stange] Use snapshot testing in the symbolicator CLI test. (#5284)
[Markus Stange] Fix two confused upgraders which didn't expect to be run on the serialized format. (#5285)
[Nicolas Chevobbe] Fix timelineSettingsHiddenTracks in High Contrast Mode. (#5250)
[Julien Wajsberg] Fix some test and non-test warnings (#5294)
[Nisarg Jhaveri] Support importing simpleperf trace files from Android Studio (#5212)
[Sean Kim] Add HTTP response status code in the profiler network tab (#5297)
[Markus Stange] Change StringTable API a bit. (#5286)
[Markus Stange] Correctly declare imported simpleperf trace profiles to be of the current version. (#5312)
[Markus Stange] Two small changes (#5313)
[Nazım Can Altınova] Show sample tooltips on sample graph hover (#5298)
Also thanks to our localizers:
en-CA: chutten
es-CL: ravmn
es-CL: ravmn
fr: Théo Chevalier
ia: Melo46
ia: Melo46
sv-SE: Andreas Pettersson
uk: Lobodzets
zh-TW: Olvcpr423