[cross_file] Add runnable example with main()#11527
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the cross_file package example by adding a runnable main entry point and a demonstration of XFile.fromData for in-memory byte construction. Corresponding tests were added to verify the new functionality. Feedback includes removing redundant type arguments in the byte list initialization and wrapping the disk-based file instantiation in a try-catch block to improve robustness across platforms like the web.
momshaddinury
force-pushed
the
main
branch
2 times, most recently
from
9d29218 to
afb5116
Compare
stuartmorgan-g
requested changes
Apr 20, 2026
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the contribution!
We want examples to be easily discoverable by users, and also to show up on pub.dev, so a main entry point for an example should be in lib/main.dart. If we only need one file, the file should be renamed.
stuartmorgan-g
requested changes
May 4, 2026
Contributor
Author
|
@stuartmorgan-g I was caught up with another PR. Will address the feedback this week. |
Contributor
Author
|
@stuartmorgan-g, is there any update to this issue? LMK if there's any feedback. |
Contributor
Author
|
@bparrishMines, can you please add the CICD label again? |
Contributor
Author
|
@bparrishMines fixed the failed readme snippet validation. Resolved the conflict. Please add the CICD label again. Thanks. |
Contributor
|
@stuartmorgan-g For the final review |
stuartmorgan-g
approved these changes
Jul 1, 2026
stuartmorgan-g
added
autosubmit
pull Bot
pushed a commit
to Klomgor/flutter
that referenced
this pull request
Jul 2, 2026
…er#188916) flutter/packages@e742106...420e135 2026-07-02 dkwingsmt@users.noreply.github.com [material_ui] Migrate api sample code to @example dartdoc directive (flutter/packages#12078) 2026-07-02 dkwingsmt@users.noreply.github.com [material_ui] Move over more API samples (flutter/packages#12092) 2026-07-01 katelovett@google.com [cupertino_ui] Migrate api sample code to @example dartdoc directive (flutter/packages#12063) 2026-07-01 katelovett@google.com [cupertino_ui] Move over more API samples (flutter/packages#12086) 2026-07-01 48776784+mackings@users.noreply.github.com [two_dimensional_scrollables] Fix TreeView horizontal hit testing (flutter/packages#11859) 2026-07-01 1063596+reidbaker@users.noreply.github.com [camera_android_camerax][tool] Integrate dart_code_linter for cyclomatic complexity checks (flutter/packages#11999) 2026-07-01 dinurymomshad.dev@gmail.com [cross_file] Add runnable example with main() (flutter/packages#11527) 2026-07-01 36861262+QuncCccccc@users.noreply.github.com [cupertino_ui] Enable `switch_test.dart` (flutter/packages#12076) 2026-07-01 jmccandless@google.com [cupertino_ui] Re-enable dialog_test.dart (flutter/packages#12057) 2026-07-01 jmccandless@google.com [cupertino_ui] Re-enable action_sheet_test.dart (flutter/packages#12055) 2026-07-01 rmolivares@renzo-olivares.dev [cupertino_ui] Migrate `bottom_tab_bar_test.dart` to `SemanticsHandle` (flutter/packages#12012) 2026-07-01 1063596+reidbaker@users.noreply.github.com [repo] Add comment style guideline to AGENTS.md (flutter/packages#12077) 2026-07-01 43054281+camsim99@users.noreply.github.com Adds pre-push readiness skill (flutter/packages#11935) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a main() entry point and an XFile.fromData demonstration to the cross_file example, so pub.dev's Pana scoring recognises that the package ships with an example.
The existing readme_excerpts.dart defined instantiateXFile() but had no top-level main(), so the file wasn't discovered as an example. This keeps the existing #docregion Instantiate block used by README.md and adds a second #docregion InstantiateFromData block alongside a main() that runs both excerpts.
The new test exercises XFile.fromData on every platform (the existing path-based test is skipped on web, which has no filesystem).
Fixes flutter/flutter#93073
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2