[camera_android_camerax][tool] Integrate dart_code_linter for cyclomatic complexity checks by reidbaker · Pull Request #11999 · flutter/packages

reidbaker · 2026-06-25T19:08:38Z

Enables cyclomatic complexity enforcement in camera_android_camerax by integrating dart_code_linter: 4.1.5 as a CLI linter check within the repository analysis tooling.
No issue this is part of the work for project oneshot.

Changelog/Version not needed changes are to shared tooling and specifically linters enabled for camera_android_camerax.

FWIW
We (@camsim99 and myself) initially aimed to enforce cognitive complexity using the dart_cognitive_complexity package. However, we encountered a dependency conflict that blocked its integration:

dart_cognitive_complexity: 2.0.0 requires analyzer: ^13.0.0.
The repository dependencies (specifically pigeon) restrict the resolved version of analyzer to <13.0.0 (which resolves to 10.0.1).
Upgrading pigeon to a published version would not work since no version on pub.dev supports analyzer: ^13.0.0.
Upgrading pigeon code felt out of scope for this effort.
Downgrading to dart_cognitive_complexity: 1.0.1 is also not possible because it requires analyzer: <7.0.0 (which conflicts with pigeon's requirement of >=10.0.0).

Pre-Review Checklist

…erax

…ols analyze command

… add unit tests

…extensibility

…ng to the runner loop

…and_test

…ole output for all scenarios

…sing helper functions

…sserting absence of case-insensitive keywords

…to linter checks

gemini-code-assist

Code Review

This pull request integrates the dart_code_linter tool into the repository's analysis command to check cyclomatic complexity for the camera_android_camerax package, updating configuration files, the analysis script, and adding corresponding tests. Feedback suggests correcting a comment mismatch from "cognitive" to "cyclomatic" complexity, and simplifying the linter execution by consistently using dart run instead of conditionally invoking flutter pub run, which also requires updating the associated unit tests and helper methods.

reidbaker · 2026-06-25T19:28:37Z

/gemini review

gemini-code-assist

Code Review

This pull request integrates the dart_code_linter tool into the repository's analysis command, enabling custom linter checks during package analysis when the dependency is declared in dev_dependencies. The linter is configured for camera_android_camerax with a cyclomatic complexity threshold of 15, and corresponding unit tests are added. Feedback suggests adding a defensive check to ensure the lib/ directory exists before running the linter to prevent errors on packages without a library directory.

…es lacking a lib/ directory

stuartmorgan-g · 2026-07-01T15:30:20Z

Upgrading pigeon code felt out of scope for this effort.

FYI I just bumped the priority on updating Pigeon to support the latest analyzer.

stuartmorgan-g · 2026-07-01T15:30:47Z


 dev_dependencies:
  build_runner: ^2.2.0
+  dart_code_linter: 4.1.5


You've audited this as safe to run in our CI and locally?

SHA1 (dart_code_linter-4.1.5.tar.gz) = 86fa1bd240a88c98a4c45f0beb43b4e7adb32735
For auditability this this is the artifact I inspected.

Looking at the code I didn't see anything suspicious.

Some things I found but I do not think are blocking:
It uses https://pub.dev/packages/pub_updater to see if there is a newer version. It works without internet access.
There is a python script to make cursor skills. It is for contributors but I found that interesting.

As concrete examples of suspicious things I looked for. Code that tried to spawn other process, code that tried to install other things, network calls, code that read env variables that looked like secrets.

stuartmorgan-g · 2026-07-01T15:35:44Z

+      final bool hasDependency = pubspec.devDependencies.containsKey(runner.dependencyName);
+      if (hasDependency) {
+        final PackageResult result = await runner.run(package);
+        if (result.state == RunState.failed) {


The strongly preferred pattern in the repo tooling is for the helper functions to return List<String> representing any errors (such than an empty array is success), and for the loop to aggregate the errors into a local errors array, then at the end to return errors.isEmpty ? PackageResult.success() : PackageResult.fail(errors);

That way, we get all the results in every run, rather than only up to the first failing thing.

Yes sorry, I authored this pr at the same time as the other one you gave this feedback on and I didnt go back to check if the pattern was violated anywhere else.

I also filed flutter/flutter#188867 which tracks changing the gradle behavior to follow this pattern.

I will personally try to remember this pattern and I have taken steps on my local machine to try to ensure this pattern does not pop up again.

camsim99

Overall LGTM % unresolved comments!

…g early

flutter-dashboard · 2026-07-01T16:29:24Z

This pull request is not mergeable in its current state, likely because of a merge conflict. Pre-submit CI jobs were not triggered. Pushing a new commit to this branch that resolves the issue will result in pre-submit jobs being scheduled.

…ation test

auto-submit · 2026-07-01T17:53:00Z

autosubmit label was removed for flutter/packages/11999, because - The status or check suite Linux analyze_downgraded stable has failed. Please fix the issues identified (or deflake) before re-applying this label.

…le dependency

…nning file dependency" This reverts commit 002182d.

reidbaker · 2026-07-01T19:24:35Z

the changes in b934bf8 add logic to no longer run the custom linters on --downgrade it caused an issue and the downgrade evals are for api compatibility.

@example

…er#188916) flutter/packages@e742106...420e135 2026-07-02 dkwingsmt@users.noreply.github.com [material_ui] Migrate api sample code to @example dartdoc directive (flutter/packages#12078) 2026-07-02 dkwingsmt@users.noreply.github.com [material_ui] Move over more API samples (flutter/packages#12092) 2026-07-01 katelovett@google.com [cupertino_ui] Migrate api sample code to @example dartdoc directive (flutter/packages#12063) 2026-07-01 katelovett@google.com [cupertino_ui] Move over more API samples (flutter/packages#12086) 2026-07-01 48776784+mackings@users.noreply.github.com [two_dimensional_scrollables] Fix TreeView horizontal hit testing (flutter/packages#11859) 2026-07-01 1063596+reidbaker@users.noreply.github.com [camera_android_camerax][tool] Integrate dart_code_linter for cyclomatic complexity checks (flutter/packages#11999) 2026-07-01 dinurymomshad.dev@gmail.com [cross_file] Add runnable example with main() (flutter/packages#11527) 2026-07-01 36861262+QuncCccccc@users.noreply.github.com [cupertino_ui] Enable `switch_test.dart` (flutter/packages#12076) 2026-07-01 jmccandless@google.com [cupertino_ui] Re-enable dialog_test.dart (flutter/packages#12057) 2026-07-01 jmccandless@google.com [cupertino_ui] Re-enable action_sheet_test.dart (flutter/packages#12055) 2026-07-01 rmolivares@renzo-olivares.dev [cupertino_ui] Migrate `bottom_tab_bar_test.dart` to `SemanticsHandle` (flutter/packages#12012) 2026-07-01 1063596+reidbaker@users.noreply.github.com [repo] Add comment style guideline to AGENTS.md (flutter/packages#12077) 2026-07-01 43054281+camsim99@users.noreply.github.com Adds pre-push readiness skill (flutter/packages#11935) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

reidbaker added 14 commits June 25, 2026 14:46

Add cyclomatic complexity linter configuration for camera_android_cam…

14be833

…erax

Configure CI target and script to run cyclomatic complexity linter

f206376

Integrate cyclomatic complexity check directly into flutter_plugin_to…

0299ea1

…ols analyze command

Remove commented-out plugin lines from analysis_options.yaml

30757fa

Refactor analyze_command linter check to a separate helper method and…

fc676e2

… add unit tests

Refactor custom linter checks into a pipeline runner list for easier …

e82d111

…extensibility

Clean up custom linter API boundaries by extracting dependency checki…

5e798fe

…ng to the runner loop

Clean up static analysis warnings in analyze_command and analyze_comm…

8b336a2

…and_test

Restrict custom linter checks to dev_dependencies only

2f96c6b

Use expectedInitialArgs to explicitly document mocks in linter tests

84abbf0

Improve tests by explicitly mocking process queues and verifying cons…

eb76af7

…ole output for all scenarios

De-duplicate pubspec writing and mock process logic in linter tests u…

d93d538

…sing helper functions

Ensure linter skip tests are robust against print string changes by a…

dd58a0d

…sserting absence of case-insensitive keywords

Add descriptive doc comments and dynamic Dart/Flutter SDK resolution …

214f051

…to linter checks

flutter-dashboard Bot added the CICD Run CI/CD label Jun 25, 2026

github-actions Bot added the p: camera label Jun 25, 2026

reidbaker added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Jun 25, 2026

gemini-code-assist Bot reviewed Jun 25, 2026

View reviewed changes

reidbaker requested review from camsim99 and stuartmorgan-g June 25, 2026 19:13

Update custom_analysis.yaml comment to say cyclomatic complexity

71559a9

github-actions Bot removed the CICD Run CI/CD label Jun 25, 2026

Simplify custom linter checks to always execute via dart run

24d9e8a

flutter-dashboard Bot added the CICD Run CI/CD label Jun 25, 2026

gemini-code-assist Bot reviewed Jun 25, 2026

View reviewed changes

Comment thread script/tool/lib/src/analyze_command.dart Outdated

reidbaker removed the request for review from stuartmorgan-g June 25, 2026 19:31

Add defensive check and tests to ensure linter does not run on packag…

ea9770a

…es lacking a lib/ directory

github-actions Bot removed the CICD Run CI/CD label Jun 25, 2026

Fix formatting and linter issues in analyze command changes

342eab8

reidbaker requested review from camsim99 and stuartmorgan-g June 30, 2026 21:41

stuartmorgan-g reviewed Jul 1, 2026

View reviewed changes

camsim99 reviewed Jul 1, 2026

View reviewed changes

Refactor custom linter checking to aggregate errors instead of failin…

64a8a90

…g early

reidbaker added the CICD Run CI/CD label Jul 1, 2026

reidbaker requested review from camsim99 and stuartmorgan-g July 1, 2026 16:29

Merge branch 'main' into add-cyclomatic-complexity-linter

db7e807

github-actions Bot removed the CICD Run CI/CD label Jul 1, 2026

reidbaker added 2 commits July 1, 2026 12:43

Fix early return on standard analysis failure and add combined aggreg…

f745d82

…ation test

Rename combined failures integration test for clarity

d14f6e1

camsim99 approved these changes Jul 1, 2026

View reviewed changes

reidbaker added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Jul 1, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 1, 2026

Fix dart_code_linter compile error during pub downgrade by pinning fi…

002182d

…le dependency

github-actions Bot removed the CICD Run CI/CD label Jul 1, 2026

reidbaker added 2 commits July 1, 2026 15:15

Revert "Fix dart_code_linter compile error during pub downgrade by pi…

c1247d4

…nning file dependency" This reverts commit 002182d.

Skip custom linter checks during downgraded analyze runs

b934bf8

reidbaker added the CICD Run CI/CD label Jul 1, 2026

reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 1, 2026

auto-submit Bot merged commit e95aa21 into flutter:main Jul 1, 2026
89 checks passed

engine-flutter-autoroll mentioned this pull request Jul 2, 2026

Roll Packages from e74210630ab8 to 420e13502995 (13 revisions) flutter/flutter#188916

Merged

Uh oh!

Conversation

reidbaker commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

reidbaker commented Jun 25, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

stuartmorgan-g commented Jul 1, 2026

Uh oh!

stuartmorgan-g Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

reidbaker Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

reidbaker Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

reidbaker Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

camsim99 left a comment

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard Bot commented Jul 1, 2026

Uh oh!

auto-submit Bot commented Jul 1, 2026

Uh oh!

reidbaker commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

reidbaker commented Jun 25, 2026 •

edited

Loading

reidbaker Jul 1, 2026 •

edited

Loading

reidbaker commented Jul 1, 2026 •

edited

Loading