[cupertino_ui] Re-enable dialog_test.dart by justinmc · Pull Request #12057 · flutter/packages

justinmc · 2026-06-29T20:58:39Z

This file used TestSemantics from the Widgets library in flutter/flutter. That approach to semantics testing is not advised, as explained in flutter/flutter#184367. I migrated to the recommended tester.semantics.find.

I also added unawaited around some futures that needed it because that lint doesn't exist in flutter/flutter.

TestSemantics to tester.semantics.find.

gemini-code-assist

Code Review

This pull request removes the skip annotation from dialog_test.dart, wraps asynchronous showCupertinoDialog calls with unawaited, and migrates semantics tests from SemanticsTester to tester.semantics.find. Feedback on the changes points out that the migration omitted assertions for the hasImplicitScrolling flag, which reduces test coverage, and recommends restoring these assertions while also reusing the defined dialogFinder.

gemini-code-assist · 2026-06-29T20:59:51Z

+    final Finder dialogFinder = find.bySemanticsLabel('Alert');
+    final SemanticsNode dialog = tester.semantics.find(find.bySemanticsLabel('Alert'));
+    expect(dialog.role, SemanticsRole.alertDialog);
+    expect(dialog, isSemantics(namesRoute: true, scopesRoute: true));
    expect(
-      semantics,
-      hasSemantics(
-        TestSemantics.root(
-          children: <TestSemantics>[
-            TestSemantics(
-              children: <TestSemantics>[
-                TestSemantics(
-                  children: <TestSemantics>[
-                    TestSemantics(
-                      flags: <SemanticsFlag>[SemanticsFlag.scopesRoute],
-                      children: <TestSemantics>[
-                        TestSemantics(
-                          flags: <SemanticsFlag>[
-                            SemanticsFlag.scopesRoute,
-                            SemanticsFlag.namesRoute,
-                          ],
-                          role: SemanticsRole.alertDialog,
-                          label: 'Alert',
-                          children: <TestSemantics>[
-                            TestSemantics(
-                              flags: <SemanticsFlag>[SemanticsFlag.hasImplicitScrolling],
-                              children: <TestSemantics>[
-                                TestSemantics(label: 'The Title'),
-                                TestSemantics(label: 'Content'),
-                              ],
-                            ),
-                            TestSemantics(
-                              flags: <SemanticsFlag>[SemanticsFlag.hasImplicitScrolling],
-                              children: <TestSemantics>[
-                                TestSemantics(
-                                  flags: <SemanticsFlag>[SemanticsFlag.isButton],
-                                  label: 'Cancel',
-                                ),
-                                TestSemantics(
-                                  flags: <SemanticsFlag>[SemanticsFlag.isButton],
-                                  label: 'OK',
-                                ),
-                              ],
-                            ),
-                          ],
-                        ),
-                      ],
-                    ),
-                  ],
-                ),
-              ],
-            ),
-          ],
-        ),
-        ignoreId: true,
-        ignoreRect: true,
-        ignoreTransform: true,
-      ),
+      find.descendant(of: dialogFinder, matching: find.bySemanticsLabel('The Title')),
+      findsOneWidget,
    );
-
-    semantics.dispose();
+    expect(
+      find.descendant(of: dialogFinder, matching: find.bySemanticsLabel('Content')),
+      findsOneWidget,
+    );
+    final SemanticsNode buttonOK = tester.semantics.find(
+      find.descendant(of: dialogFinder, matching: find.bySemanticsLabel('OK')),
+    );
+    expect(buttonOK, isSemantics(isButton: true));
+    final SemanticsNode buttonCancel = tester.semantics.find(
+      find.descendant(of: dialogFinder, matching: find.bySemanticsLabel('Cancel')),
+    );
+    expect(buttonCancel, isSemantics(isButton: true));


During the migration from SemanticsTester to tester.semantics.find, the assertions verifying the hasImplicitScrolling flag on the scrollable containers (the title/content section and the actions section) were lost. This reduces the test coverage for critical accessibility behaviors of the dialog.\n\nAdditionally, dialogFinder is defined but not reused when retrieving the dialog semantics node.\n\nThis suggestion reuses dialogFinder, extracts other finders for readability, and restores the assertions for hasImplicitScrolling by verifying the parent nodes of the title and buttons.

final Finder dialogFinder = find.bySemanticsLabel('Alert');\n final SemanticsNode dialog = tester.semantics.find(dialogFinder);\n expect(dialog.role, SemanticsRole.alertDialog);\n expect(dialog, isSemantics(namesRoute: true, scopesRoute: true));\n\n final Finder titleFinder = find.descendant(of: dialogFinder, matching: find.bySemanticsLabel('The Title'));\n expect(titleFinder, findsOneWidget);\n final SemanticsNode titleNode = tester.semantics.find(titleFinder);\n expect(titleNode.parent, isSemantics(hasImplicitScrolling: true));\n\n expect(\n find.descendant(of: dialogFinder, matching: find.bySemanticsLabel('Content')),\n findsOneWidget,\n );\n\n final Finder okFinder = find.descendant(of: dialogFinder, matching: find.bySemanticsLabel('OK'));\n final SemanticsNode buttonOK = tester.semantics.find(okFinder);\n expect(buttonOK, isSemantics(isButton: true));\n expect(buttonOK.parent, isSemantics(hasImplicitScrolling: true));\n\n final Finder cancelFinder = find.descendant(of: dialogFinder, matching: find.bySemanticsLabel('Cancel'));\n final SemanticsNode buttonCancel = tester.semantics.find(cancelFinder);\n expect(buttonCancel, isSemantics(isButton: true));

Renzo-Olivares · 2026-06-29T21:41:08Z

  });

  testWidgets('Has semantic annotations', (WidgetTester tester) async {
-    final semantics = SemanticsTester(tester);


nit: Should we use SemanticsHandle to ensure semantics is initialized like below (plus dispose at the end of the test)? I'm not sure how necessary this is but I've been doing it in the migrations I've done.

final SemanticsHandle handle = tester.ensureSemantics();

Done in ab8a7ce.

semantics is enabled by default, I think this is not needed

Renzo-Olivares · 2026-06-29T21:46:37Z

  });

  testWidgets('showCupertinoDialog - custom barrierLabel', (WidgetTester tester) async {
-    final semantics = SemanticsTester(tester);


https://github.com/flutter/packages/pull/12057/changes#r3494863310

Renzo-Olivares · 2026-06-29T21:55:29Z

-      semantics,
-      isNot(
-        includesNodeWith(label: 'Custom label', flags: <SemanticsFlag>[SemanticsFlag.namesRoute]),
+      find.semantics.byPredicate(


I think this can just be

expect(find.semantics.byLabel('Custom label'), findsNothing);

Yeah I guess the flags part is not important here. That sure simplifies things.

QuncCccccc

LGTM!

chunhtai · 2026-07-01T05:10:02Z

      ),
    );

+    final Finder dialogFinder = find.bySemanticsLabel('Alert');


this can use the isSemantics(children:) to assert the subtree

Done in 4ee13ef

I was hoping to use your new isSemantics role parameter too, but I guess we'll have to wait until we bump the SDK.

Renzo-Olivares

LGTM

@example

…er#188916) flutter/packages@e742106...420e135 2026-07-02 dkwingsmt@users.noreply.github.com [material_ui] Migrate api sample code to @example dartdoc directive (flutter/packages#12078) 2026-07-02 dkwingsmt@users.noreply.github.com [material_ui] Move over more API samples (flutter/packages#12092) 2026-07-01 katelovett@google.com [cupertino_ui] Migrate api sample code to @example dartdoc directive (flutter/packages#12063) 2026-07-01 katelovett@google.com [cupertino_ui] Move over more API samples (flutter/packages#12086) 2026-07-01 48776784+mackings@users.noreply.github.com [two_dimensional_scrollables] Fix TreeView horizontal hit testing (flutter/packages#11859) 2026-07-01 1063596+reidbaker@users.noreply.github.com [camera_android_camerax][tool] Integrate dart_code_linter for cyclomatic complexity checks (flutter/packages#11999) 2026-07-01 dinurymomshad.dev@gmail.com [cross_file] Add runnable example with main() (flutter/packages#11527) 2026-07-01 36861262+QuncCccccc@users.noreply.github.com [cupertino_ui] Enable `switch_test.dart` (flutter/packages#12076) 2026-07-01 jmccandless@google.com [cupertino_ui] Re-enable dialog_test.dart (flutter/packages#12057) 2026-07-01 jmccandless@google.com [cupertino_ui] Re-enable action_sheet_test.dart (flutter/packages#12055) 2026-07-01 rmolivares@renzo-olivares.dev [cupertino_ui] Migrate `bottom_tab_bar_test.dart` to `SemanticsHandle` (flutter/packages#12012) 2026-07-01 1063596+reidbaker@users.noreply.github.com [repo] Add comment style guideline to AGENTS.md (flutter/packages#12077) 2026-07-01 43054281+camsim99@users.noreply.github.com Adds pre-push readiness skill (flutter/packages#11935) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

justinmc added 2 commits June 29, 2026 13:56

Re-enabled dialog_test.

c2bbd60

TestSemantics to tester.semantics.find.

Unawaited

cf7cc29

justinmc self-assigned this Jun 29, 2026

flutter-dashboard Bot added the CICD Run CI/CD label Jun 29, 2026

github-actions Bot added triage-framework Should be looked at in framework triage p: cupertino_ui labels Jun 29, 2026

justinmc requested review from Renzo-Olivares and chunhtai June 29, 2026 20:59

justinmc mentioned this pull request Jun 29, 2026

(Test cross-imports) Don't cross-import test utils flutter/flutter#182636

Open

gemini-code-assist Bot reviewed Jun 29, 2026

View reviewed changes

justinmc requested review from QuncCccccc and elliette June 29, 2026 21:16

Renzo-Olivares reviewed Jun 29, 2026

View reviewed changes

justinmc added 2 commits June 29, 2026 15:57

SemanticsHandle

ab8a7ce

Simplify byPredicate to byLabel

b335d18

github-actions Bot removed the CICD Run CI/CD label Jun 29, 2026

justinmc mentioned this pull request Jun 30, 2026

[cupertino_ui] Remove widgets import from menu_anchor_test.dart #12068

Merged

No ensureSemantics needed.

d977332

justinmc added the CICD Run CI/CD label Jun 30, 2026

QuncCccccc approved these changes Jun 30, 2026

View reviewed changes

Renzo-Olivares mentioned this pull request Jun 30, 2026

[cupertino_ui] Enable switch_test.dart #12076

Merged

11 tasks

chunhtai reviewed Jul 1, 2026

View reviewed changes

justinmc added 2 commits July 1, 2026 09:28

Merge branch 'main' into cross-imports-dialog

fa16d3f

Test whole tree.

4ee13ef

github-actions Bot removed the CICD Run CI/CD label Jul 1, 2026

justinmc added the CICD Run CI/CD label Jul 1, 2026

justinmc requested review from QuncCccccc and chunhtai July 1, 2026 16:34

justinmc requested a review from Renzo-Olivares July 1, 2026 16:34

justinmc mentioned this pull request Jul 1, 2026

Move away from TestSemantics and towards fine grained semantics testing flutter/flutter#184367

Open

Renzo-Olivares approved these changes Jul 1, 2026

View reviewed changes

justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 1, 2026

auto-submit Bot merged commit 48e670c into flutter:main Jul 1, 2026
13 checks passed

justinmc deleted the cross-imports-dialog branch July 1, 2026 17:46

engine-flutter-autoroll mentioned this pull request Jul 2, 2026

Roll Packages from e74210630ab8 to 420e13502995 (13 revisions) flutter/flutter#188916

Merged

Uh oh!

Conversation

justinmc commented Jun 29, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants