[cupertino_ui] Enable switch_test.dart#12076
Merged
auto-submit[bot] merged 1 commit intoJul 1, 2026
Merged
Conversation
github-actions
Bot
added
triage-framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request re-enables the switch_test.dart test file by removing the @Skip annotation and removes the SemanticsTester import and its usages. The review feedback points out that removing SemanticsTester without enabling semantics will cause object.debugSemantics to be null, leading to null-check crashes. It is recommended to use tester.ensureSemantics() and register its disposal via addTearDown to resolve this issue.
| ); | ||
| final semanticsTester = SemanticsTester(tester); | ||
|
|
||
| await tester.pumpWidget( |
Contributor
There was a problem hiding this comment.
Removing SemanticsTester without enabling semantics will cause object.debugSemantics to be null, leading to a null-check crash when object.debugSemantics! is called. To fix this, use tester.ensureSemantics() and register its disposal via addTearDown.
final SemanticsHandle semantics = tester.ensureSemantics();
addTearDown(semantics.dispose);
await tester.pumpWidget(| ); | ||
| final semanticsTester = SemanticsTester(tester); | ||
|
|
||
| await tester.pumpWidget( |
Contributor
There was a problem hiding this comment.
Removing SemanticsTester without enabling semantics will cause object.debugSemantics to be null, leading to a null-check crash when object.debugSemantics! is called. To fix this, use tester.ensureSemantics() and register its disposal via addTearDown.
final SemanticsHandle semantics = tester.ensureSemantics();
addTearDown(semantics.dispose);
await tester.pumpWidget(
QuncCccccc
force-pushed
the
enable_cupertino_switch_test
branch
from
39cd313 to
8ca6b91
Compare
Contributor
Author
QuncCccccc
changed the title
switch_test.dart
Renzo-Olivares
approved these changes
Jun 30, 2026
Renzo-Olivares
left a comment
Renzo-Olivares
left a comment
Contributor
There was a problem hiding this comment.
LGTM, w/ small comments about ensureSemantics.
QuncCccccc
force-pushed
the
enable_cupertino_switch_test
branch
from
8ca6b91 to
f4c8d80
Compare
QuncCccccc
added
the
autosubmit
pull Bot
pushed a commit
to Klomgor/flutter
that referenced
this pull request
Jul 2, 2026
…er#188916) flutter/packages@e742106...420e135 2026-07-02 dkwingsmt@users.noreply.github.com [material_ui] Migrate api sample code to @example dartdoc directive (flutter/packages#12078) 2026-07-02 dkwingsmt@users.noreply.github.com [material_ui] Move over more API samples (flutter/packages#12092) 2026-07-01 katelovett@google.com [cupertino_ui] Migrate api sample code to @example dartdoc directive (flutter/packages#12063) 2026-07-01 katelovett@google.com [cupertino_ui] Move over more API samples (flutter/packages#12086) 2026-07-01 48776784+mackings@users.noreply.github.com [two_dimensional_scrollables] Fix TreeView horizontal hit testing (flutter/packages#11859) 2026-07-01 1063596+reidbaker@users.noreply.github.com [camera_android_camerax][tool] Integrate dart_code_linter for cyclomatic complexity checks (flutter/packages#11999) 2026-07-01 dinurymomshad.dev@gmail.com [cross_file] Add runnable example with main() (flutter/packages#11527) 2026-07-01 36861262+QuncCccccc@users.noreply.github.com [cupertino_ui] Enable `switch_test.dart` (flutter/packages#12076) 2026-07-01 jmccandless@google.com [cupertino_ui] Re-enable dialog_test.dart (flutter/packages#12057) 2026-07-01 jmccandless@google.com [cupertino_ui] Re-enable action_sheet_test.dart (flutter/packages#12055) 2026-07-01 rmolivares@renzo-olivares.dev [cupertino_ui] Migrate `bottom_tab_bar_test.dart` to `SemanticsHandle` (flutter/packages#12012) 2026-07-01 1063596+reidbaker@users.noreply.github.com [repo] Add comment style guideline to AGENTS.md (flutter/packages#12077) 2026-07-01 43054281+camsim99@users.noreply.github.com Adds pre-push readiness skill (flutter/packages#11935) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#182636 and flutter/flutter#188395
This PR:
widgets/semantics_tester.dartfromswitch_test.dart.SemanticsTesterusages.@Skipannotation and moves the file to thetest/folder.Pre-Review Checklist
[shared_preferences]///).