[pigeon] add support for analyzer 13 and 14 - #12358
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the analyzer dependency in the pigeon package to support versions 13 and 14, bumping the package version to 27.3.1. The changes adapt the AST parsing logic in pigeon_lib_internal.dart to use Argument and NamedArgument instead of Expression and NamedExpression, and simplify formal parameter parsing. Feedback suggests improving an error message in pigeon_lib_internal.dart to print the specific invalid argument instead of the entire expression.
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM with minor comments.
tarrinneal
added
the
autosubmit
…r#190719) flutter/packages@4e3f83d...fc22143 2026-08-07 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 058e0af to 6b182d2 (4 revisions) (flutter/packages#12394) 2026-08-07 269567208+reidbaker-agent@users.noreply.github.com [camera_android_camerax][tool] Migrate complexity checks to package:cognitive_complexity (flutter/packages#12356) 2026-08-06 mdebbar@google.com [camera_web] Remove invalid @js annotation on extension type constructors (flutter/packages#12384) 2026-08-06 tarrinneal@gmail.com [pigeon] add support for analyzer 13 and 14 (flutter/packages#12358) 2026-08-06 katelovett@google.com [cupertino_ui, material_ui] Fix bad doc references (flutter/packages#12381) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
updates ast crawling to use new argument classes. supports major analyzer versions 13 and 14.
fixes flutter/flutter#187145