[material_ui] Use super parameters in more places - #12460
Merged
Conversation
This is work towards dart-lang/sdk#59226 The lint rule use_super_parameters has a bug such that it didn't previously report these cases. But they will be reported soon.
github-actions
Bot
added
triage-framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors constructors in several files, including drawer.dart, dropdown_menu_form_field.dart, input_decorator.dart, and will_pop_test.dart, to use Dart's super-initializer parameters instead of manually passing arguments to the super constructor. There are no review comments, and I have no feedback to provide.
Piinks
added
triage-design
elliette
added
the
override: no versioning needed
Member
|
See https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version for versioning instructions |
elliette
removed
the
override: no versioning needed
9 tasks
elliette
reviewed
Aug 25, 2026
elliette
approved these changes
Aug 25, 2026
11 tasks
This was referenced Sep 2, 2026
pull Bot
pushed a commit
to Mu-L/flutter
that referenced
this pull request
Sep 2, 2026
…r#192191) flutter/packages@7a7912f...18fe786 2026-09-02 32538273+ValentinVignal@users.noreply.github.com [path_parsing] Fix deprecation lints (flutter/packages#12704) 2026-09-02 srawlins@google.com [material_ui] Use super parameters in more places (flutter/packages#12460) 2026-09-02 21270878+elliette@users.noreply.github.com [material_ui] Add a README and placeholders for migrating gen_defaults templates (flutter/packages#12714) 2026-09-01 victor.orozco@cloudsufi.com [image_picker] Add native tests for image, metadata, photo-asset, and PHPicker save utilities (flutter/packages#12536) 2026-09-01 lozhkovoi@gmail.com [material_ui] Port routes_transition_test to material_ui (flutter/packages#12634) 2026-09-01 engine-flutter-autoroll@skia.org Roll Flutter from c8c5e3b to 0cbd1a4 (23 revisions) (flutter/packages#12712) 2026-09-01 32538273+ValentinVignal@users.noreply.github.com [material_ui] Remove !chrome in text_field_test.dart (flutter/packages#12548) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is work towards dart-lang/sdk#59226
The lint rule use_super_parameters has a bug such that it didn't previously report these cases. But they will be reported soon.
Pre-Review Checklist
[shared_preferences]///).Test exempt, as this code is covered by existing static and runtime checks.