[material_ui] Remove !chrome in text_field_test.dart - #12548
Merged
auto-submit[bot] merged 3 commits intoSep 1, 2026
Merged
Conversation
github-actions
Bot
added
p: material_ui
triage-design
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the @TestOn('!chrome') annotation and the associated TODO comment from packages/material_ui/test/text_field_test.dart, enabling the test suite to run on Chrome. There are no review comments, and I have no feedback to provide.
Member
|
It looks like one of the tests cases is failing on web: |
ValentinVignal
force-pushed
the
material-ui/test/remove-no-chrome-in-text-field-tests
branch
from
August 26, 2026 09:30
6efac2c to
1392c8a
Compare
Contributor
Author
|
I had to add few |
QuncCccccc
reviewed
Aug 27, 2026
| TargetPlatform.linux, | ||
| TargetPlatform.windows, | ||
| }), | ||
| skip: isContextMenuProvidedByPlatform, |
Contributor
There was a problem hiding this comment.
I think skipping these tests when isContextMenuProvidedByPlatform is valid.
QuncCccccc
reviewed
Aug 27, 2026
| TargetPlatform.linux, | ||
| TargetPlatform.windows, | ||
| }), | ||
| skip: isContextMenuProvidedByPlatform, |
Contributor
There was a problem hiding this comment.
nit: Can we add a comment above this line to mention it is intended, like
| // Regression test for https://github.com/flutter/flutter/issues/168578. | ||
| final controller = TextEditingController(text: 'abc def ghi'); | ||
| addTearDown(controller.dispose); | ||
| testWidgets( |
Contributor
There was a problem hiding this comment.
Seems these are only format changes. Can we revert them?
Contributor
Author
There was a problem hiding this comment.
Those formatting changes are because I added a skip: kIsWeb at the end. Is there a way to add it without having those formatting changes?
Contributor
There was a problem hiding this comment.
I see. I think it's fine.
QuncCccccc
approved these changes
Aug 27, 2026
| // Regression test for https://github.com/flutter/flutter/issues/168578. | ||
| final controller = TextEditingController(text: 'abc def ghi'); | ||
| addTearDown(controller.dispose); | ||
| testWidgets( |
Contributor
There was a problem hiding this comment.
I see. I think it's fine.
Member
|
Re-running the timed out tests to deflake (I don't think they are related to this change) |
ValentinVignal
force-pushed
the
material-ui/test/remove-no-chrome-in-text-field-tests
branch
from
September 1, 2026 06:24
a2fa596 to
1358242
Compare
elliette
added
the
autosubmit
This was referenced Sep 2, 2026
pull Bot
pushed a commit
to Mu-L/flutter
that referenced
this pull request
Sep 2, 2026
…r#192191) flutter/packages@7a7912f...18fe786 2026-09-02 32538273+ValentinVignal@users.noreply.github.com [path_parsing] Fix deprecation lints (flutter/packages#12704) 2026-09-02 srawlins@google.com [material_ui] Use super parameters in more places (flutter/packages#12460) 2026-09-02 21270878+elliette@users.noreply.github.com [material_ui] Add a README and placeholders for migrating gen_defaults templates (flutter/packages#12714) 2026-09-01 victor.orozco@cloudsufi.com [image_picker] Add native tests for image, metadata, photo-asset, and PHPicker save utilities (flutter/packages#12536) 2026-09-01 lozhkovoi@gmail.com [material_ui] Port routes_transition_test to material_ui (flutter/packages#12634) 2026-09-01 engine-flutter-autoroll@skia.org Roll Flutter from c8c5e3b to 0cbd1a4 (23 revisions) (flutter/packages#12712) 2026-09-01 32538273+ValentinVignal@users.noreply.github.com [material_ui] Remove !chrome in text_field_test.dart (flutter/packages#12548) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#92134
It seems the issue is already closed and fixed, so I'm attempting to remove this TODO
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2