Make plugin autoclonetype always on #1826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azidar
requested changes
Mar 19, 2021
azidar
approved these changes
Mar 23, 2021
jackkoenig
added
the
Please Merge
jackkoenig
pushed a commit
that referenced
this pull request
Feb 28, 2023
This adds an experimental new SMTLib and Btor2 emitter that converts a firrtl module into a format suitable for open source model checkers. The format generally follows the behavior of yosys' write_smt2 and write_btor commands. To generate btor2 for the module in m.fir run > ./utils/bin/firrtl -i m.fir -E experimental-btor2 for SMT: > ./utils/bin/firrtl -i m.fir -E experimental-smt2 If you have a design with multiple clocks or an asynchronous reset, try out the new StutteringClockTransform. You can designate any input of type Clock to be your global simulation clock using the new GlobalClockAnnotation. If your toplevel module instantiates submodules, you need to inline them if you want the submodule logic to be included in the formal model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on to #1804, make the compiler plugin autoclonetype be always on and thus used in chisel3 itself.
Contributor Checklist
docs/src?Type of Improvement
API Impact
As described in the release notes in #1804 and reflected in the test change, this will cause issues for any Bundle that inherits from a Bundle in
chisel3.utilif the code is not also compiled using the compiler plugin. Thus, this change can only occur on the major version bump.Backend Code Generation Impact
Desired Merge Strategy
Release Notes
Always generate
cloneTypemethods for Bundles using the compiler plugin. This causes a binary and source incompatible change for any Chisel code that does not use the compiler plugin but extends aBundlein other code that does. All Chisel users should use the compiler plugin.Reviewer Checklist (only modified by reviewer)
Please Merge?