[26.0] Fix data source tool redirect back to Galaxy SPA#22720
Merged
bgruening merged 1 commit intoMay 19, 2026
Conversation
The mako-template removal in 7634165 deleted the JavaScript `top.location.href = '/'` redirect that returned the user to Galaxy after an external data source import in a new tab. The replacement `show_ok_message` rendered a static page, leaving the new tab stranded on a "job queued" message instead of navigating back to the SPA. Restore the redirect with a 302 to `/?notification=tool-submitted` from both `ToolRunner.index` and `ASync.index`, and have `Home.vue` surface a `useToast` notification on landing (then strip the query param so a reload doesn't re-fire it). Fixes galaxyproject#22671
github-actions
Bot
added
area/UI-UX
area/testing
area/testing/api
area/testing/selenium
labels
guerler
approved these changes
May 19, 2026
github-project-automation
Bot
moved this from Needs Review
to Done
in Galaxy Dev - weeklies
Member
|
Will redeploy EU now, this might still be needed in GTA |
nsoranzo
added a commit
that referenced
this pull request
Jun 3, 2026
Fix: ``` /home/runner/work/galaxy/galaxy/client/src/entry/analysis/modules/Home.vue Warning: 1:1 warning Component name "Home" should always be multi-word vue/multi-word-component-names Error: 48:5 error The "computed" property should be above the "mounted" property on line 35 vue/order-in-components ``` Broken in #22720 .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mako-template removal in 7634165 deleted the JavaScript
top.location.href = '/'redirect that returned the user to Galaxy after an external data source import in a new tab. The replacementshow_ok_messagerendered a static page, leaving the new tab stranded on a "job queued" message instead of navigating back to the SPA.Restore the redirect with a 302 to
/?notification=tool-submittedfrom bothToolRunner.indexandASync.index, and haveHome.vuesurface auseToastnotification on landing (then strip the query param so a reload doesn't re-fire it).Fixes #22671
How to test the changes?
(Select all options that apply)
License