test(the-framework): give the re-home polls a budget a CI runner can meet#1154
Merged
Conversation
…meet The #1122 re-home test failed on CI at 6578ms against a 6s ceiling: 300 attempts 20ms apart, waiting on an events tail, a project resolve, a git worktree add and a spawn. It timed out rather than observed a wrong result, and it took main red with it. The loops return the moment what they wait for lands, so a 30s ceiling costs nothing when things are fast and only shows up on a real failure. Closes #1153
suleimansh
added
bug
suleimansh
marked this pull request as ready for review
July 25, 2026 11:19
This was referenced Jul 25, 2026
suleimansh
added a commit
that referenced
this pull request
Jul 25, 2026
… timeout (#1160) The 30s ceiling from #1154 was too generous in the wrong direction: a single re-home test runs two of these polls, so two slow waits alone reached the suite's 60s per-test timeout and a slow test became a file timeout. 15s each still clears the 6.5s the failing CI run needed, and leaves the real git work between them inside the cap. Follows #1153
This was referenced Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1153.
The #1122 re-home test fails on CI at 6578ms against a 6s ceiling — 300 attempts 20ms apart, waiting on an events tail, a project resolve, a
git worktree addand a spawn. It timed out rather than observed a wrong result. Seen onmainat 47049ab (run 30136805342) and twice on an unrelated branch (run 30155239647, first attempt and re-run), so it is not tied to any one change.One shared
POLL_ATTEMPTS(1500 × 20ms = 30s) for the three polls in that file. They all return the moment what they wait for lands, so the larger cap costs nothing on a fast machine and only shows up on a real failure.1277 tests green locally. Test-only, no changeset.