test(the-framework): keep the re-home poll under the suite's per-test timeout#1160
Merged
Conversation
… timeout The 30s ceiling from #1154 was too generous in the wrong direction: a single re-home test runs two of these polls, so two slow waits alone reached the suite's 60s per-test timeout and a slow test became a file timeout. 15s each still clears the 6.5s the failing CI run needed, and leaves the real git work between them inside the cap. Follows #1153
suleimansh
added
bug
suleimansh
marked this pull request as ready for review
July 25, 2026 13:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #1153 / #1154.
I raised that poll ceiling to 30s, which fixed the 6s timeout and introduced a worse one: a single re-home test runs two of those polls, so two slow waits alone hit the suite's 60s
--test-timeoutand the wholedaemon-workspace.test.jsfile timed out instead (seen on #1156).15s each clears the 6.5s the original failing run needed, with the real git work between them still inside the cap.
1286 tests green locally. Test-only, no changeset.