Skip to content

fix(dashboard): name what "New" makes, and keep the session list titled when empty#1156

Merged
suleimansh merged 2 commits into
mainfrom
fix/1147-new-session-label
Jul 25, 2026
Merged

fix(dashboard): name what "New" makes, and keep the session list titled when empty#1156
suleimansh merged 2 commits into
mainfrom
fix/1147-new-session-label

Conversation

@suleimansh

@suleimansh suleimansh commented Jul 25, 2026

Copy link
Copy Markdown
Member

Closes #1147.

  • NewNew session, in all three forms of the button (start in this project, pick a project, add one first). The dropdown's aria-label already said "New session", so this only brings the visible label in line.
  • RecentsRecent sessions, and the heading now renders even when the list is empty, with No sessions yet. under it — your second comment on the issue.

Driven in Chrome at 1280px and 900px: both labels fit the sidebar, no horizontal overflow, and the empty state reads Recent sessions / No sessions yet.

dashboard 429 tests (the two that asserted the old label updated), typecheck + build clean, patch changeset.

@suleimansh

Copy link
Copy Markdown
Member Author

CI here failed on daemon-workspace.test.js timing out, not on anything in this PR — it is the poll budget I raised too far in #1154 colliding with the suite's 60s per-test timeout. Fix in #1160; this will go green on a rebase once that lands.

…ed when empty

"New" did not say new what. It starts a session, so it says so, in all three
of its forms (start here, pick a project, add one first).

The list below it is titled "Recent sessions" and keeps its heading when
there is nothing in it, so "No sessions yet." reads as the state of that
list rather than a lonely line in the sidebar.

Closes #1147
@suleimansh
suleimansh force-pushed the fix/1147-new-session-label branch from bfa96fc to a8155ae Compare July 25, 2026 13:59
@suleimansh
suleimansh marked this pull request as ready for review July 25, 2026 14:16
@suleimansh
suleimansh merged commit 754b194 into main Jul 25, 2026
0 of 2 checks passed
@suleimansh
suleimansh deleted the fix/1147-new-session-label branch July 25, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"New" => "New session"

1 participant