feat(aci): Disable error monitor create button #103544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| return hasEveryAccess(['alerts:write'], {organization}); | ||
| } | ||
|
|
||
| return detectorTypeIsUserCreateable(detectorType); |
Contributor
There was a problem hiding this comment.
Bug: Inconsistent authorization allows monitor creation.
When detectorType is provided and user-createable, the hook returns true without checking the user's alerts:write permission. This allows users without proper permissions to see an enabled "Create Monitor" button for user-createable detector types. The permission check is only performed when detectorType is null, creating an inconsistent authorization check.
| ), | ||
| } | ||
| ); | ||
| const permissionTooltipText = detectorTypeIsUserCreateable(detector.type) |
Member
There was a problem hiding this comment.
Won't this only show if you're unable to edit the monitor?
Member
There was a problem hiding this comment.
oh canEdit inherited behavior huh
| } | ||
| ) | ||
| : t( | ||
| 'This monitor is managed by Sentry. Only organization owners and managers can edit it.' |
Member
Author
There was a problem hiding this comment.
For now yeah, only org owners/managers can access the edit screen for error monitors
scttcper
approved these changes
Nov 18, 2025
malwilley
deleted the
malwilley/feat/disable-error-monitor-create-button
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ID-1104