Skip to content

ref(crons): Simplify is_muted logic using all() instead of double negative #103732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2025
Merged

ref(crons): Simplify is_muted logic using all() instead of double negative #103732

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sentry/monitors/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ def get_attrs(self, item_list, user, **kwargs):
# A monitor is muted only if it has environments AND all of them are muted
is_muted_data = {
item.id: bool(monitor_envs_by_id.get(item.id, []))
and not any(not env.is_muted for env in monitor_envs_by_id.get(item.id, []))
and all(env.is_muted for env in monitor_envs_by_id.get(item.id, []))
for item in item_list
}

Expand Down
Loading