ref(crons): Simplify is_muted logic using all() instead of double negative #103732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ative Address code review feedback from Dan to replace the double negative `not any(not env.is_muted ...)` with the clearer `all(env.is_muted ...)`. Both are logically equivalent but all() is much more readable.
github-actions
bot
added
the
Scope: Backend
wedamija
approved these changes
Nov 20, 2025
evanpurkhiser
deleted the
evanpurkhiser/ref-crons-simplify-is-muted-logic-using-all-instead-of-double-negative
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address code review feedback from Dan to replace the double negative
not any(not env.is_muted ...)with the clearerall(env.is_muted ...).Both are logically equivalent but all() is much more readable.