feat(detectors): Preserve page filters + env in DetectorLink #105055
Conversation
github-actions
bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| : { | ||
| pathname: makeMonitorDetailsPathname(org.slug, detector.id), | ||
| query, | ||
| }; |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| : detector.name; | ||
|
|
||
| // Preserve page filters when navigating to detector details | ||
| const query = pick(location.query, ['start', 'end', 'statsPeriod', 'environment']); |
There was a problem hiding this comment.
Is this necessary? The monitor details page reads from page filters, so it should be setting the date/env filters appropriately
There was a problem hiding this comment.
It doesn't seem to work right now? If I change the date range on the uptime monitors list and click a monitor, we lose the parameters
There was a problem hiding this comment.
Oh, it looks like it works when selecting from the page filters but not if you use the chart
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-detectors-preserve-page-filters-env-in-detectorlink
branch
from
4ffb1b3 to
c2fcf22
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-detectors-preserve-page-filters-env-in-detectorlink
branch
from
c2fcf22 to
07898ea
Compare
| href = link; | ||
| } else { | ||
| const pathname = link.pathname ?? ''; | ||
| const search = link.search ?? (link.query ? `?${qs.stringify(link.query)}` : ''); |
There was a problem hiding this comment.
Trailing ? in URLs when query object is empty
Low Severity
When openInNewTab is true and link.query is an empty object {}, the condition link.query ? evaluates to true since empty objects are truthy. However, qs.stringify({}) returns an empty string, resulting in search being just "?" with no parameters. This causes URLs to have a trailing ? when navigating without any page filters set. The check needs to verify the query object has properties, not just that it exists.
evanpurkhiser
deleted the
evanpurkhiser/feat-detectors-preserve-page-filters-env-in-detectorlink
branch
No description provided.