ref: Remove unmigratable repositories code path#115905
Merged
evanpurkhiser merged 1 commit intoMay 20, 2026
Merged
Conversation
The `?status=unmigratable` branch on the org repositories endpoint has no frontend caller. The UI that drove it (`migrationWarnings.tsx` and the surrounding "Upgrade" buttons on the integrations directory) was deleted in #17823 back in March 2020, and nothing in `static/` has passed `status=unmigratable` since. Removes: - `UNMIGRATABLE_PROVIDERS` and the corresponding endpoint branch - `get_unmigratable_repositories` on the base `RepositoryIntegration` - overrides on bitbucket, bitbucket_server, github, vsts, perforce - the example integration's no-op override - the four `test_status_unmigratable*` test cases The plugin -> integration auto-migration on integration install (`migrate_repo` task + `sentry.plugins.migrator.Migrator`) is left alone -- that's a separate mechanism from this dead query-parameter branch and still runs for orgs that install a SCM integration while the legacy plugin is enabled. A small frontend follow-up to drop the now-dead `'unmigratable'` literal from the `status?:` type unions in `repoQueryOptions.ts` will ship as a separate PR (per `static/` vs `src/` deploy split).
github-actions
Bot
added
the
Scope: Backend
saponifi3d
approved these changes
May 20, 2026
Contributor
saponifi3d
left a comment
saponifi3d
left a comment
There was a problem hiding this comment.
🙏 thanks for cleaning up deadcode! lgtm!
evanpurkhiser
deleted the
evanpurkhiser/ref-remove-unmigratable-repositories-code-path
branch
evanpurkhiser
added a commit
that referenced
this pull request
May 20, 2026
…115906) Follow-up to #115905, which removed the backend `?status=unmigratable` path on the org repositories endpoint. The `'unmigratable'` literal in the two `status?:` type unions in `static/app/utils/repositories/repoQueryOptions.ts` was the last reference to that mode anywhere in `static/`, and nothing has passed it since the migration UI was removed in #17823 (March 2020).
JonasBa
pushed a commit
that referenced
this pull request
May 21, 2026
The `?status=unmigratable` branch on `/api/0/organizations/<org>/repos/` has no frontend caller. The UI that drove it (`migrationWarnings.tsx` and the related "Upgrade" buttons in the org integrations directory) was deleted in #17823 back in March 2020, and nothing in `static/` has passed `status=unmigratable` since. The backend has been zombie code for ~6 years. This PR removes: - `UNMIGRATABLE_PROVIDERS` and the corresponding `elif` branch in `OrganizationRepositoriesEndpoint.get()` - `get_unmigratable_repositories` on the base `RepositoryIntegration` - the overrides on bitbucket, bitbucket_server, github, vsts, perforce - the example integration's no-op override - the four `test_status_unmigratable*` cases in `tests/sentry/integrations/api/endpoints/test_organization_repositories.py` The plugin -> integration auto-migration on integration install (`migrate_repo` task + `sentry.plugins.migrator.Migrator`) is intentionally left alone. That's a separate mechanism from this dead query-param branch and still runs when an org installs a SCM integration with the legacy plugin enabled. A one-line frontend follow-up to drop the now-dead `'unmigratable'` literal from the `status?:` type unions in `static/app/utils/repositories/repoQueryOptions.ts` will ship as a separate PR (per the `static/` vs `src/` deploy split documented in AGENTS.md).
JonasBa
pushed a commit
that referenced
this pull request
May 21, 2026
…115906) Follow-up to #115905, which removed the backend `?status=unmigratable` path on the org repositories endpoint. The `'unmigratable'` literal in the two `status?:` type unions in `static/app/utils/repositories/repoQueryOptions.ts` was the last reference to that mode anywhere in `static/`, and nothing has passed it since the migration UI was removed in #17823 (March 2020).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
?status=unmigratablebranch on/api/0/organizations/<org>/repos/has no frontend caller. The UI that drove it (migrationWarnings.tsxand the related "Upgrade" buttons in the org integrations directory) was deleted in #17823 back in March 2020, and nothing instatic/has passedstatus=unmigratablesince. The backend has been zombie code for ~6 years.This PR removes:
UNMIGRATABLE_PROVIDERSand the correspondingelifbranch inOrganizationRepositoriesEndpoint.get()get_unmigratable_repositorieson the baseRepositoryIntegrationtest_status_unmigratable*cases intests/sentry/integrations/api/endpoints/test_organization_repositories.pyThe plugin -> integration auto-migration on integration install (
migrate_repotask +sentry.plugins.migrator.Migrator) is intentionally left alone. That's a separate mechanism from this dead query-param branch and still runs when an org installs a SCM integration with the legacy plugin enabled.A one-line frontend follow-up to drop the now-dead
'unmigratable'literal from thestatus?:type unions instatic/app/utils/repositories/repoQueryOptions.tswill ship as a separate PR (per thestatic/vssrc/deploy split documented in AGENTS.md).