fix(workflows): allow team admins to update alerts solely connected to their projects - #123385
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit eac45d0. Configure here.
cvxluo
approved these changes
Sep 1, 2026
| Determine if the requesting user can edit every workflow in the sequence. | ||
|
|
||
| Organization alert writers can delete organization-level workflows. Otherwise, | ||
| Organization alert writers can edit any workflow. Otherwise, |
Contributor
There was a problem hiding this comment.
might be helpful to include a comment that this includes deletion
hobzcalvin
reviewed
Sep 1, 2026
Comment on lines
+440
to
+447
| if raw_idlist: | ||
| requested_ids = set(to_valid_int_id_list("id", raw_idlist)) | ||
| if requested_ids != {workflow.id for workflow in workflows}: | ||
| raise PermissionDenied | ||
|
|
||
| if not can_edit_workflows(workflows, request): | ||
| raise PermissionDenied | ||
|
|
Contributor
There was a problem hiding this comment.
Wondering if there's enough common code between this and delete() to make some private helper
malwilley
force-pushed
the
malwilley/project-scoped-workflow-create-v2
branch
from
September 1, 2026 23:34
eac45d0 to
6248224
Compare
Contributor
Sentry Snapshot Testing
|
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
malwilley
force-pushed
the
malwilley/project-scoped-workflow-create-v2
branch
from
September 2, 2026 17:08
6248224 to
ef7f7d2
Compare
Base automatically changed from
malwilley/project-scoped-workflow-create-v1
to
master
September 2, 2026 18:41
malwilley
force-pushed
the
malwilley/project-scoped-workflow-create-v2
branch
from
September 2, 2026 19:59
ef7f7d2 to
85df8b7
Compare
…coped-workflow-create-v2 # Conflicts: # src/sentry/workflow_engine/endpoints/organization_workflow_index.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building on top of other changes in the stack which do the same for the POST and DELETE endpoints.
The goal of all these PRs is to make it possible for team admins (who have the
alerts:writescope on the project level, but not on the org-level) to create, edit, and delete workflows which are solely connected to projects they own.