fix(js): Set useApiRequests initial isLoading state to true#39586
Merged
malwilley merged 1 commit intoOct 4, 2022
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
evanpurkhiser
approved these changes
Oct 4, 2022
malwilley
deleted the
malwilley/fix/use-api-requests-is-loading-initial-state
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches the behavior of AsyncComponent:
sentry/static/app/components/asyncComponent.tsx
Line 194 in 9197dc5
Right now
renderComponentis returning the success view on first render because of this.