Conversation
malwilley
changed the title
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #63128 +/- ##
=======================================
Coverage 81.35% 81.35%
=======================================
Files 5205 5205
Lines 230706 230732 +26
Branches 39862 39868 +6
=======================================
+ Hits 187682 187706 +24
- Misses 37267 37268 +1
- Partials 5757 5758 +1
|
trillville
pushed a commit
that referenced
this pull request
Jan 19, 2024
…tack frames (try 2) (#63128) There are a couple problems with the current code mapping flow that are addressed in this commit: 1. Code mapping logic is duplicated (and slightly different) in stacktrace linking and suspect commits. To ensure a consistent experience, stacktrace linking and suspect commits should apply code mappings in a similar way. By introducing a new function convert_stacktrace_frame_path_to_source_path(), we can use it in both locations to guarantee that the implementations do not diverge. (Note that this function is tested but not yet used - will update stacktrace linking and suspect commits in a separate PR) 2. Code mappings only apply to filename, not abs_path Certain platforms have trouble creating valid code mappings because filename only contains the file name and the folder structure is in abs_path (see #43516 (comment)). By adding it as a fallback check in convert_stacktrace_frame_path_to_source_path() we can support these platforms. Related to the above concern with abs_path, I also modified get_sorted_code_mapping_configs() to check for absolute paths in the stack_root while sorting code mappings. Without this check, the sorting does not work as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-submitting #62971 because it broke CI and had to be reverted. Pasting PR description below:
There are a couple problems with the current code mapping flow that are addressed in this PR:
To ensure a consistent experience, stacktrace linking and suspect commits should apply code mappings in a similar way. By introducing a new function convert_stacktrace_frame_path_to_source_path(), we can use it in both locations to guarantee that the implementations do not diverge. (Note that this function is tested but not yet used - will update stacktrace linking and suspect commits in a separate PR)
Certain platforms have trouble creating valid code mappings because filename only contains the file name and the folder structure is in abs_path (see #43516 (comment)). By adding it as a fallback check in convert_stacktrace_frame_path_to_source_path() we can support these platforms.
Related to the above concern with abs_path, I also modified get_sorted_code_mapping_configs() to check for absolute paths in the stack_root while sorting code mappings. Without this check, the sorting does not work as expected.