feat(code-mappings): Support using abs_path when applying code mappings#62768
Merged
feat(code-mappings): Support using abs_path when applying code mappings#62768
Conversation
github-actions
bot
added
the
Scope: Backend
Member
|
woo thanks!! |
malwilley
force-pushed
the
malwilley/fix/code-mappings-abs-path
branch
from
1b61b7a to
d0a014c
Compare
malwilley
force-pushed
the
malwilley/fix/code-mappings-abs-path
branch
from
d0a014c to
0680ff4
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #62768 +/- ##
==========================================
- Coverage 81.34% 81.34% -0.01%
==========================================
Files 5207 5207
Lines 231053 231006 -47
Branches 39925 39914 -11
==========================================
- Hits 187948 187908 -40
+ Misses 37332 37327 -5
+ Partials 5773 5771 -2
|
malwilley
force-pushed
the
malwilley/fix/code-mappings-abs-path
branch
from
0680ff4 to
3cc4989
Compare
wedamija
approved these changes
Jan 12, 2024
Member
wedamija
left a comment
wedamija
left a comment
There was a problem hiding this comment.
Looks good to me, looks a lot cleaner too
armenzg
approved these changes
Jan 15, 2024
Member
armenzg
left a comment
armenzg
left a comment
There was a problem hiding this comment.
@malwilley so grateful for these fixes 🎉 A lot of spaghetti code that needed attention.
…mappings-abs-path
trillville
pushed a commit
that referenced
this pull request
Jan 19, 2024
…gs (#62768) Fixes #61730 Fixes #43516 - Converts stacktrace-link endpoint to use `convert_stacktrace_frame_path_to_source_path()` - Converts suspect commits to use `convert_stacktrace_frame_path_to_source_path()` Importantly, this will allow users to set up code mappings which reference the `abs_path` instead of just `filename`.
This was referenced Jan 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61730
Fixes #43516
Followup to #63128 which added
convert_stacktrace_frame_path_to_source_path().convert_stacktrace_frame_path_to_source_path()convert_stacktrace_frame_path_to_source_path()Importantly, this will allow users to set up code mappings which reference the
abs_pathinstead of justfilename.