ref(suspect-commits): GA suspect-commits-all-frames#65043
Merged
Conversation
github-actions
bot
added
the
Scope: Backend
malwilley
commented
Feb 12, 2024
|
|
||
| PREFERRED_GROUP_OWNERS = 1 | ||
| PREFERRED_GROUP_OWNER_AGE = timedelta(days=7) | ||
| DEBOUNCE_CACHE_KEY = lambda group_id: f"process-commit-context-{group_id}" |
Member
Author
There was a problem hiding this comment.
Removed all references to DEBOUNCE_CACHE_KEY and PREFFERRED_GROUP_OWNER*. The previous method used this to run once a week, but the new method only runs once for new issues.
malwilley
commented
Feb 12, 2024
| for record in to_be_deleted: | ||
| record.delete() | ||
|
|
||
| current_owners = owners.filter( |
Member
Author
There was a problem hiding this comment.
No need to check for existing suspect commits anymore since this is only run once per issue
malwilley
commented
Feb 12, 2024
| code_mappings = get_sorted_code_mapping_configs(project) | ||
|
|
||
| frames = event_frames or [] | ||
| munged = munged_filename_and_frames(event_platform, frames, "munged_filename", sdk_name) |
Member
Author
There was a problem hiding this comment.
No need to call the munging function anymore since the new logic does it later on #62768
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #65043 +/- ##
==========================================
+ Coverage 81.41% 81.42% +0.01%
==========================================
Files 5254 5254
Lines 232323 232119 -204
Branches 45607 45564 -43
==========================================
- Hits 189139 189006 -133
+ Misses 37290 37243 -47
+ Partials 5894 5870 -24
|
ceorourke
approved these changes
Feb 13, 2024
Member
ceorourke
left a comment
ceorourke
left a comment
There was a problem hiding this comment.
I've never seen a more beautiful pr 😭
malwilley
force-pushed
the
malwilley/ref/ga-suspect-commits
branch
from
7e905ce to
b3c2cae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature flag has been enabled in SaaS for some time now. This PR removes the flag and all now-unused logic.
Most of the tests were already re-written for the new methods, so there are a lot of deleted tests which should not decrease coverage. Any cases that didn't look covered were modified to use the new methods.
The important changes are in
tasks/commit_context.pyandpost_process.py