fix(schema): allow klausGateway.slack channelMode, channelAllowlist, dmMode#209
Merged
Merged
Conversation
…dmMode The klaus-gateway subchart (0.20.x) introduced channel-mode routing, but the umbrella schema's klausGateway.slack block (additionalProperties: false) was never extended. Any installation setting these keys — e.g. gazelle's swarmgeist channel pilot (giantswarm-configs#762) — failed the helm upgrade at schema validation, leaving the HelmRelease stuck in Failed (PD incident #6917). Mirror the subchart's schema for the three keys (same types and enums).
QuentinBisson
added a commit
that referenced
this pull request
Jul 22, 2026
Stacked on #209 (umbrella schema). #209 fixes only the umbrella, but the umbrella forwards the whole klausGateway block to the connectivity HelmRelease via forwardAllValues, so the same channelMode/dmMode/ channelAllowlist keys must be declared in the connectivity schema too or the Additional-property failure just moves downstream once the umbrella reconciles. Also retires the dead slack.dmOnly key: klaus-gateway removed SLACK_DM_ONLY (replaced by dmMode + channelMode). Dropped from values.yaml and both schemas. Migration: dmOnly:true -> dmMode:serve + channelMode:none; dmOnly:false -> dmMode:redirect + channelMode:all.
paurosello
marked this pull request as ready for review
July 22, 2026 07:18
QuentinBisson
approved these changes
Jul 22, 2026
QuentinBisson
added a commit
that referenced
this pull request
Jul 22, 2026
…210) * fix(schema): allow klausGateway.slack channelMode, channelAllowlist, dmMode The klaus-gateway subchart (0.20.x) introduced channel-mode routing, but the umbrella schema's klausGateway.slack block (additionalProperties: false) was never extended. Any installation setting these keys — e.g. gazelle's swarmgeist channel pilot (giantswarm-configs#762) — failed the helm upgrade at schema validation, leaving the HelmRelease stuck in Failed (PD incident #6917). Mirror the subchart's schema for the three keys (same types and enums). * fix: mirror slack channel-mode keys to connectivity schema, drop dmOnly Stacked on #209 (umbrella schema). #209 fixes only the umbrella, but the umbrella forwards the whole klausGateway block to the connectivity HelmRelease via forwardAllValues, so the same channelMode/dmMode/ channelAllowlist keys must be declared in the connectivity schema too or the Additional-property failure just moves downstream once the umbrella reconciles. Also retires the dead slack.dmOnly key: klaus-gateway removed SLACK_DM_ONLY (replaced by dmMode + channelMode). Dropped from values.yaml and both schemas. Migration: dmOnly:true -> dmMode:serve + channelMode:none; dmOnly:false -> dmMode:redirect + channelMode:all. --------- Co-authored-by: Jose Armesto <github@armesto.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
channelMode,channelAllowlist, anddmModeto the umbrella chart'sklausGateway.slackschema, mirroring the klaus-gateway 0.20.x subchart schema (same types and enums).Why
Fixes PagerDuty incident #6917 (
FluxGiantswarmHelmReleaseFailedon gazelle).giantswarm/giantswarm-configs#762 set these keys for gazelle's swarmgeist channel pilot. The klaus-gateway subchart supports them, but the umbrella schema (
additionalProperties: false) was never extended, so every reconcile fails before rendering:gazelle is pinned on chart 2.2.0 (last good deploy 2026-07-21 10:38 UTC); all newer releases (2.2.1–2.4.0, incl. the muster 1.x bump) are blocked behind this validation failure.
Verification
helm lintwith gazelle's failingklausGateway.slackvalues: fails onmain(6 schema errors), passes with this change.dmOnly(superseded bydmMode); left in the umbrella schema untouched to stay surgical.