fix: slack channel-mode keys in connectivity schema + retire dmOnly#210
Merged
Conversation
…dmMode The klaus-gateway subchart (0.20.x) introduced channel-mode routing, but the umbrella schema's klausGateway.slack block (additionalProperties: false) was never extended. Any installation setting these keys — e.g. gazelle's swarmgeist channel pilot (giantswarm-configs#762) — failed the helm upgrade at schema validation, leaving the HelmRelease stuck in Failed (PD incident #6917). Mirror the subchart's schema for the three keys (same types and enums).
Stacked on #209 (umbrella schema). #209 fixes only the umbrella, but the umbrella forwards the whole klausGateway block to the connectivity HelmRelease via forwardAllValues, so the same channelMode/dmMode/ channelAllowlist keys must be declared in the connectivity schema too or the Additional-property failure just moves downstream once the umbrella reconciles. Also retires the dead slack.dmOnly key: klaus-gateway removed SLACK_DM_ONLY (replaced by dmMode + channelMode). Dropped from values.yaml and both schemas. Migration: dmOnly:true -> dmMode:serve + channelMode:none; dmOnly:false -> dmMode:redirect + channelMode:all.
QuentinBisson
force-pushed
the
fix/klausgateway-slack-surface-schema
branch
from
July 22, 2026 00:07
6d7623f to
f57fbe0
Compare
QuentinBisson
changed the base branch from
main
to
fix-klausgateway-slack-channel-mode-schema
July 22, 2026 00:07
QuentinBisson
changed the title
paurosello
marked this pull request as ready for review
July 22, 2026 07:19
Base automatically changed from
fix-klausgateway-slack-channel-mode-schema
to
main
July 22, 2026 07:19
fiunchinho
approved these changes
Jul 22, 2026
QuentinBisson
enabled auto-merge (squash)
July 22, 2026 07:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #209 — merge that first (this PR is based on its branch and GitHub will retarget to
mainonce #209 lands).What
#209 adds
channelMode/channelAllowlist/dmModeto the umbrellavalues.schema.json. This PR adds the delta #209 doesn't cover:klausGatewayblock to theagentic-platform-connectivityHelmRelease viaforwardAllValues. Itsslackschema is alsoadditionalProperties: falseand lacks these keys, so fixing only the umbrella relocatesAdditional property channelMode is not allowedto the connectivity release once the umbrella upgrade reconciles. Same three keys now declared there too.dmOnly. klaus-gateway removedSLACK_DM_ONLY/slack.dmOnly(replaced bydmMode+channelMode) and ignores a leftover value. Dropped fromvalues.yamland both schemas.Migration (breaking for installs still setting dmOnly)
dmOnly: true→dmMode: serve+channelMode: nonedmOnly: false(channels served, DMs redirected) →dmMode: redirect+channelMode: allgraveler config giantswarm-configs#742 sets
dmOnly: trueand must migrate before this merges. gazelle (#762) already uses the new keys.Verification
helm linton both charts: default values pass, surface-mode values pass, anddmOnlyis now rejected (Additional property dmOnly is not allowed).