Skip to content

Merge master into docs-preparation#2863

Merged
semmle-qlci merged 110 commits intogithub:docs-preparationfrom
shati-patel:master
Feb 18, 2020
Merged

Merge master into docs-preparation#2863
semmle-qlci merged 110 commits intogithub:docs-preparationfrom
shati-patel:master

Conversation

@shati-patel
Copy link
Copy Markdown
Contributor

There's another small change to the QL handbook here, but this mergeback hopefully won't affect any of the other CodeQL documentation topics people are working on!

@felicitymay - could you review/approve please? 🙏

RasmusWL and others added 30 commits January 27, 2020 13:07
Now we recognize `[(x,y)] = [(1,2)]` -- in itself not a widely used idiom, but
more of a warmup excersize for me
This changes the location from the import statement, to the actual expression
$ python2 -W default -c 'import posixfile'
-c:1: DeprecationWarning: The posixfile module is deprecated; fcntl.lockf() provides better locking

https://docs.python.org/2.7/library/posixfile.html
The predicate

```
argumentValueFlowsThrough(ArgumentNode arg, OutNode out, CallContext cc)
```

has been generalized to

```
argumentValueFlowsThrough(
  DataFlowCall call, ArgumentNode arg, Node out, ContentOption contentIn,
  ContentOption contentOut
)
```

This enables us to summarize normal flow-through (as before), getters, setters,
as well as getter-setters.
With internal update to qltest it will not actually do something.

- also remove it from the tests that never needed it.
@shati-patel shati-patel requested review from a team and jf205 as code owners February 18, 2020 12:27
@shati-patel shati-patel removed request for a team and jf205 February 18, 2020 12:27
@felicitymay
Copy link
Copy Markdown
Contributor

Many thanks for creating this merge PR @shati-patel. I guess we should wait for the tests to complete, but otherwise this looks great. JMOG

@semmle-qlci semmle-qlci merged commit ba67faf into github:docs-preparation Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.