Skip to content
This repository was archived by the owner on Apr 12, 2019. It is now read-only.

Integrated drone and other standard files#9

Merged
metalmatze merged 13 commits into
masterfrom
drone
Nov 13, 2016
Merged

Integrated drone and other standard files#9
metalmatze merged 13 commits into
masterfrom
drone

Conversation

@tboerger

Copy link
Copy Markdown
Member

No description provided.

Comment thread Makefile

.PHONY: lint
lint:
@which golint > /dev/null; if [ $$? -ne 0 ]; then \

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according #11, we have to use golint -min_confidence=0.9 currently if we merge this after #11.

@lunny

lunny commented Nov 13, 2016

Copy link
Copy Markdown
Member

LGTM

@strk

strk commented Nov 13, 2016

Copy link
Copy Markdown
Member

Why giving up travis completely ?
From a quick look it seems that Travis is testing against multiple Go versions while Drone isn't (yet?).
Why not having both bots keep an eye on the code, until/unless they perform the same checks ?

@lunny

lunny commented Nov 13, 2016

Copy link
Copy Markdown
Member

Travis is too slow. Drone also can be configed Go versions.

@strk

strk commented Nov 13, 2016

Copy link
Copy Markdown
Member

Let's have it configured before dropping travis

@tboerger

Copy link
Copy Markdown
Member Author

Drone also got matrix builds and we define the build power and flexibility. Travis is slow and now we are really dogfooding as far as possible

@tboerger

Copy link
Copy Markdown
Member Author

This pr is already complex enough, we can add the matrix later on as well

@metalmatze

Copy link
Copy Markdown

LGTM

@metalmatze
metalmatze merged commit 0807b51 into master Nov 13, 2016
@metalmatze
metalmatze deleted the drone branch November 13, 2016 14:20
@metalmatze

Copy link
Copy Markdown

Let's not forget to add the matrix later. Good job! 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants