Implement Animation Blend Shape Tracks #53865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduz
force-pushed
the
implement-blend-shape-tracks
branch
from
a5dcc44
to
a703df2
Compare
reduz
force-pushed
the
implement-blend-shape-tracks
branch
from
a703df2
to
913b37f
Compare
|
Posting for future use.
This is an animation done entirely with blend shapes. |
reduz
force-pushed
the
implement-blend-shape-tracks
branch
2 times, most recently
from
5894766
to
92989ba
Compare
fire
reviewed
Oct 16, 2021
| <method name="get_active_material" qualifiers="const"> | ||
| <return type="Material" /> | ||
| <argument index="0" name="surface" type="int" /> | ||
| <description> | ||
| Returns the [Material] that will be used by the [Mesh] when drawing. This can return the [member GeometryInstance3D.material_override], the surface override [Material] defined in this [MeshInstance3D], or the surface [Material] defined in the [Mesh]. For example, if [member GeometryInstance3D.material_override] is used, all surfaces will return the override material. | ||
| </description> | ||
| </method> | ||
| <method name="get_blend_shape_count" qualifiers="const"> |
There was a problem hiding this comment.
set_blend_shape_name() would match set bone name.
|
@fire It does not seem to work, but it seems like this is a problem of the importer, not so much a problem of the code I added. |
fire
reviewed
Oct 16, 2021
|
Other diffs. |
* New track type BLEND_SHAPE * Blend shapes are imported via this new track type * Processing is more optimized (no longer relies on variants) * Modified the Blend Shape API in MeshInstance3D to use indices rather than StringNames (more optimizes) * Promo: Fixed a small bug in gizmo updating in Node3D that affected performance Dedicated BlendShape tracks are required for both optimization and eventually implementing them in animation compression.
reduz
force-pushed
the
implement-blend-shape-tracks
branch
from
92989ba
to
ae1c016
Compare
|
@fire Pushed changes, please try the PR again. |
fire
approved these changes
Oct 16, 2021
akien-mga
approved these changes
Oct 16, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dedicated BlendShape tracks are required for both optimization and eventually implementing them in animation compression.