-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Markdown syntax highlighting to the script editor #78312
Add Markdown syntax highlighting to the script editor #78312
Conversation
Just curious, is there any issue with 4.x compatibility on this PR? Would love to see this in an upcoming release! |
To my knowledge, there's nothing blocking this PR, but it needs a review. Since GDC is ongoing and many core contributors are there, this may take a while. |
Ah that makes total sense, thanks for the reply! |
// `__bold__` syntax is not supported as color regions must begin with a symbol, | ||
// not a character that is valid in an identifier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this because the script editor assumes that's GDScript?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's because of #30586 (which still seems to partially exist in 4.x, at least for _
).
3592d44
to
3eb8b0a
Compare
Is this still pending review? Would love to have this feature natively. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is such an easy merge, looking forward to it 💖
|
Thanks! |
Excited for this as well! |
Is it possible to export this SyntaxHighlighter to a GDScript class? |
There are some limitations due to how CodeEdit's highlighting works, but it's good enough for a lot of Markdown files out there already. It could be made significantly better if
add_color_region()
had a way to enforce the start to be at the beginning of a line, or with only leading whitespace 🙂Preview