-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LOD selection in compatibility backend and clean up LOD code #92287
Conversation
It might be worth checking if this fixes shadows in orthographic camera sometimes using very low-detail shadow LODs (despite camera Z far being low), while the mesh is being drawn with its full detail. |
Do you have a bug report/MRP for that? I don't think this PR will help in that situation, but I can look into it |
Pancake issue is gone MRP: |
You can see it on the last GIF in this issue: #73472 The round object has a square shadow. |
Thanks! Tested that MRP and I can confirm that this fixes the issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm no rendering expert, but the overall code change looks sensible to me, and this would be a welcome bugfix to test in beta1.
Thanks! |
Fixes: #67479
Fixes: #89394
Fixes: #78664
Fixes: #73472
Fixes: #78422
I have another PR coming to fix- #81995, but I separated these changes out in the meantime as these are very safe changes
CC @mrjustaguy