Skip to content

FE-1304: add badge to ds - #9155

Merged
alex-e-leon merged 11 commits into
mainfrom
FE-1304-add-badge-to-ds
Aug 10, 2026
Merged

FE-1304: add badge to ds#9155
alex-e-leon merged 11 commits into
mainfrom
FE-1304-add-badge-to-ds

Conversation

@alex-e-leon

Copy link
Copy Markdown
Contributor

🌟 What is the purpose of this PR?

Adds badge component

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

@vercel

vercel Bot commented Aug 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Ready Ready Preview Aug 10, 2026 8:46am
hashdotdesign-tokens Ready Ready Preview Aug 10, 2026 8:46am
petrinaut Ready Ready Preview Aug 10, 2026 8:46am

@cursor

cursor Bot commented Aug 4, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
This is a breaking API change for any consumer of the old inline Badge (minor bump in changeset); overlay behavior is new but limited to ds-components with no app imports found yet.

Overview
Badge is redesigned from an inline label chip (children, colorScheme, sizes, icons) into a notification-style overlay: wrap any anchor in children, pass counts/labels via content, and control corner position, alignTo="circle" for avatars, hide, and numeric max capping (default 99+).

Layout is split into BaseBadge (relative wrap + container-query corner placement) and a badgeRecipe-styled pill (Chip colors, square/round, dot when content is omitted). BaseBadge is exported from the package; BadgeProps is no longer exported from main.ts.

Avatar now treats shape as optional with default circle, matching typical usage with badge stories.

Ladle stories move from Legacy to Components/Badge and document colors, content variants, and positioning across icons, buttons, avatars, and text.

Reviewed by Cursor Bugbot for commit 40d1dd5. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team area/apps > hash.design Affects the `hash.design` design site (app) labels Aug 4, 2026
@alex-e-leon
alex-e-leon force-pushed the FE-1304-add-badge-to-ds branch from 1fc2c58 to 90f0310 Compare August 4, 2026 09:28
@vercel
vercel Bot temporarily deployed to Preview – hashdotdesign-tokens August 4, 2026 09:30 Inactive
@vercel
vercel Bot temporarily deployed to Preview – petrinaut August 4, 2026 09:33 Inactive
@alex-e-leon
alex-e-leon requested a review from lunelson August 4, 2026 12:17
@alex-e-leon
alex-e-leon enabled auto-merge August 4, 2026 12:18
lunelson
lunelson previously approved these changes Aug 7, 2026
@alex-e-leon
alex-e-leon added this pull request to the merge queue Aug 7, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Aug 7, 2026
@alex-e-leon
alex-e-leon added this pull request to the merge queue Aug 10, 2026
Merged via the queue into main with commit 340b649 Aug 10, 2026
49 checks passed
@alex-e-leon
alex-e-leon deleted the FE-1304-add-badge-to-ds branch August 10, 2026 09:34
This was referenced Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/apps > hash.design Affects the `hash.design` design site (app) area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

2 participants