Skip to content

FE-1310: add banner to ds - #9163

Merged
alex-e-leon merged 8 commits into
mainfrom
FE-1310-add-banner-to-ds
Aug 7, 2026
Merged

FE-1310: add banner to ds#9163
alex-e-leon merged 8 commits into
mainfrom
FE-1310-add-banner-to-ds

Conversation

@alex-e-leon

Copy link
Copy Markdown
Contributor

🌟 What is the purpose of this PR?

Add Banner component

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

@vercel

vercel Bot commented Aug 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Ready Ready Preview Aug 5, 2026 12:19pm
hashdotdesign-tokens Ready Ready Preview Aug 5, 2026 12:19pm
petrinaut Ready Ready Preview Aug 5, 2026 12:19pm

@cursor

cursor Bot commented Aug 5, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Chip variant renames are a breaking API change for Chip consumers; Tone widening plus narrowed props on Button/inputs may surface TypeScript errors in downstream code.

Overview
Introduces a new Banner compound component (title, description, actions, dismiss) with five tones, three visual variants (solid / soft / outline), configurable leading icons (including custom nodes), optional dismiss, and container-query layout so actions wrap on narrow banners. It is exported from the package and covered by Ladle stories; a patch changeset records the release.

Tone in form-shared now includes warning and success, used by Banner. Other components narrow what they accept: Button and selectable Menu items no longer allow warning/success tones; Checkbox, Radio, and Toggle adjust their allowed tone unions accordingly.

Chip variant names are renamed for consistency: filldefined, fillLightsoft, subtleghost (recipe, types, stories, and defaults updated).

Adds diamondExclamation to Icon for the error banner default glyph.

Reviewed by Cursor Bugbot for commit 0a6567c. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread libs/@hashintel/ds-components/src/components/Banner/banner.recipe.ts Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ce7538f. Configure here.

Comment thread libs/@hashintel/ds-components/src/components/Banner/banner.recipe.ts Outdated
@alex-e-leon
alex-e-leon added this pull request to the merge queue Aug 7, 2026
Merged via the queue into main with commit f82a980 Aug 7, 2026
49 checks passed
@alex-e-leon
alex-e-leon deleted the FE-1310-add-banner-to-ds branch August 7, 2026 13:39
@hash-release hash-release Bot mentioned this pull request Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/apps > hash.design Affects the `hash.design` design site (app) area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

2 participants