Skip to content

FE-1319: add button group to ds - #9164

Merged
alex-e-leon merged 6 commits into
mainfrom
FE-1319-add-button-group-to-ds
Aug 7, 2026
Merged

FE-1319: add button group to ds#9164
alex-e-leon merged 6 commits into
mainfrom
FE-1319-add-button-group-to-ds

Conversation

@alex-e-leon

Copy link
Copy Markdown
Contributor

🌟 What is the purpose of this PR?

Add ButtonGroup component

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

@vercel

vercel Bot commented Aug 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Ready Ready Preview Aug 5, 2026 4:25pm
hashdotdesign-tokens Ready Ready Preview Aug 5, 2026 4:25pm
petrinaut Ready Ready Preview Aug 5, 2026 4:25pm

@cursor

cursor Bot commented Aug 5, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
New presentational DS component and a non-breaking data-variant attribute on Button; no auth, data, or app logic changes.

Overview
Adds a ButtonGroup layout component to @hashintel/ds-components for grouping buttons with spaced (gap) or segmented (shared borders) layouts, plus reverse, alignedTo, and noWrap.

Segmented styling uses a CVA recipe that squares interior corners, overlaps borders, and handles solid button gaps and tooltip wrapper nesting via data-variant and data-row-*. useSegmentedRows measures wrap breaks (ResizeObserver/MutationObserver) and clones children with row-start/end markers so corner radii stay correct on multi-line groups.

Button now sets data-variant (default solid) so the group can target child styles. The package exports ButtonGroup; Ladle stories cover wrapping, alignment, and mixed variants. Button stories get minor layout tweaks only.

Reviewed by Cursor Bugbot for commit 876552b. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team area/apps > hash.design Affects the `hash.design` design site (app) labels Aug 5, 2026
@alex-e-leon
alex-e-leon force-pushed the FE-1319-add-button-group-to-ds branch from 2404ced to 8d112c8 Compare August 5, 2026 14:57

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 75a0faf. Configure here.

@alex-e-leon
alex-e-leon added this pull request to the merge queue Aug 7, 2026
Merged via the queue into main with commit 3735fc7 Aug 7, 2026
49 checks passed
@alex-e-leon
alex-e-leon deleted the FE-1319-add-button-group-to-ds branch August 7, 2026 13:42
@hash-release hash-release Bot mentioned this pull request Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/apps > hash.design Affects the `hash.design` design site (app) area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

2 participants