Fix behavior execution for Javascript runners - #99
Merged
Conversation
Alfred-Mountfield
removed their request for review
December 17, 2021 10:44
litvand
reviewed
Dec 17, 2021
litvand
left a comment
litvand
left a comment
Contributor
There was a problem hiding this comment.
The first change is good
litvand
self-requested a review
December 17, 2021 12:52
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
Only behaviors for the first agents are executed. This is a fix to this.
🔗 Related links
🔍 What does this change?
For optimization, the
agent_statewas reused in the javascript runner. This PR removes the optimization, as behavior indices were borked after reusing.🛡 Tests