Skip to content

Fix behavior execution for Javascript runners #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TimDiekmann merged 3 commits into from
Dec 17, 2021
Merged

Fix behavior execution for Javascript runners #99

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8be843b
Fix behavior execution for Javascript runners
TimDiekmann Dec 16, 2021
c17c9ba
Merge branch 'main' into td/fix-behaviors
TimDiekmann Dec 17, 2021
db1b6c3
Apply suggestions from review
TimDiekmann Dec 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/engine/src/simulation/package/state/packages/behavior_execution/package.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,9 +171,9 @@ const run_task = (experiment, sim, task_message, group_state, group_context) =>

const n_agents_in_group = group_state.n_agents();
for (var i_agent = 0; i_agent < n_agents_in_group; ++i_agent) {

// Reuse `agent_state` and `agent_ctx` objects.
agent_state = group_state.get_agent(i_agent, agent_state);
// TODO: Reuse `agent_state` objects. When using the old `agent_state`, the indices for behaviors are borked
agent_state = group_state.get_agent(i_agent, null);
// Reuse `agent_ctx` objects.
agent_ctx = group_context.get_agent(i_agent, agent_ctx);

const behavior_ids = agent_state[behavior_ids_field_key];
Expand All @@ -198,7 +198,6 @@ const run_task = (experiment, sim, task_message, group_state, group_context) =>
behavior.fn(agent_state, agent_ctx);
postprocess(agent_state);
}
agent_state.behavior_index = i_behavior;
}

return {
Expand Down