Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve logging in semantic tokens rule #4135

Merged

Conversation

soulomoon
Copy link
Collaborator

@soulomoon soulomoon commented Mar 11, 2024

Switch use_ to useE to capture meaningful error.

@soulomoon soulomoon marked this pull request as ready for review March 11, 2024 10:10
@michaelpj
Copy link
Collaborator

Do we need to do this manually everywhere? What does this do, concretely?

@michaelpj
Copy link
Collaborator

(I am pretty confused about how all this works tbh!)

@soulomoon
Copy link
Collaborator Author

Do we need to do this manually everywhere? What does this do, concretely?

If we can print out the throwed error in use_ in the general handling of rules, then we do not have to do it everywhere,
It must be captured some where and hidden. But tbh, I am not sure where it is.

@soulomoon soulomoon enabled auto-merge (squash) March 11, 2024 19:44
@soulomoon soulomoon merged commit bd7c9ba into haskell:master Mar 11, 2024
39 checks passed
@soulomoon
Copy link
Collaborator Author

BadDependency is swallow here Is around here.

pure (Nothing, ([ideErrorText file $ T.pack $ show e | not $ isBadDependency e],Nothing))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants