Skip to content

Allow to create new team#2375

Merged
haiodo merged 6 commits into
mainfrom
feature/TSK-108
Nov 17, 2022
Merged

Allow to create new team#2375
haiodo merged 6 commits into
mainfrom
feature/TSK-108

Conversation

@muhtimur

@muhtimur muhtimur commented Nov 14, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Signed-off-by: muhtimur timur.mukhamedishin@xored.com

Contribution checklist

Brief description

Now we can create teams

image

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

TSK-108

muhtimur
Allow to create new team
9355186 
Signed-off-by: muhtimur <timur.mukhamedishin@xored.com>
haiodo
haiodo reviewed Nov 14, 2022
View reviewed changes
Comment thread packages/core/src/classes.ts Outdated
private: boolean
members: Arr<Ref<Account>>
archived: boolean
icon?: Asset

@haiodo haiodo Nov 14, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not need it for generic spaces.

@muhtimur muhtimur Nov 14, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed it with Denis, and he told me that the easiest way to add a custom icon is to create this field in Space interface. But there is one more way -- to create a mixin for Space which will show some presenter with the custom icon. So, is it better to use 2nd way?

@haiodo haiodo Nov 14, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it only will be used for Team? If so please use it there, and have options for Space unified components. No need for mixin here.

@haiodo haiodo Nov 14, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not mix Core and UI in one.

@muhtimur muhtimur Nov 14, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it is used only for teams but in future we will have to use it for userpics in direct messages

@muhtimur muhtimur Nov 14, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a presenter component for Team

muhtimur added 2 commits November 15, 2022 00:42
muhtimur
Add team presenter
47cdbc8 
Signed-off-by: muhtimur <timur.mukhamedishin@xored.com>
muhtimur
Remove unused import
b9b6bb2 
Signed-off-by: muhtimur <timur.mukhamedishin@xored.com>
haiodo
haiodo reviewed Nov 15, 2022
View reviewed changes
Comment thread packages/core/src/classes.ts Outdated
private: boolean
members: Arr<Ref<Account>>
archived: boolean
presenter?: AnyAttribute

@haiodo haiodo Nov 15, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need to extend base Space class?

@haiodo haiodo Nov 15, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use some of view.mixin.* if you need presenters.

@muhtimur muhtimur Nov 15, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected it

muhtimur added 3 commits November 15, 2022 13:36
muhtimur
Correct team presenter
b405dc4 
Signed-off-by: muhtimur <timur.mukhamedishin@xored.com>
muhtimur
Remove unused import
b34052a 
Signed-off-by: muhtimur <timur.mukhamedishin@xored.com>
muhtimur
Correct specials selection
b57effc 
Signed-off-by: muhtimur <timur.mukhamedishin@xored.com>
@haiodo
haiodo merged commit 2cd894e into main Nov 17, 2022
@haiodo
haiodo deleted the feature/TSK-108 branch November 17, 2022 04:31
mrsadman99 pushed a commit that referenced this pull request Nov 18, 2022
Anton Brechka
Merge branch 'main' into TSK-399
914582f 
* main:
  Allow to create new team (#2375)
  Fix popups (#2384)
  Fix workspace join (#2383)
  Fix separation by productId (#2382)
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
@muhtimur
Allow to create new team (hcengineering#2375)
b8a14ce 
Signed-off-by: muhtimur <timur.mukhamedishin@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BykhovDenis BykhovDenis Awaiting requested review from BykhovDenis
1 more reviewer
@haiodo haiodo haiodo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@muhtimur @haiodo