Skip to content

Fix separation by productId#2382

Merged
haiodo merged 1 commit into
mainfrom
fix-product-separation
Nov 16, 2022
Merged

Fix separation by productId#2382
haiodo merged 1 commit into
mainfrom
fix-product-separation

Conversation

@haiodo

@haiodo haiodo commented Nov 15, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Andrey Sobolev haiodo@gmail.com

Contribution checklist

Brief description

Proper support for productId.

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@haiodo
haiodo requested a review from BykhovDenis November 15, 2022 18:34
@haiodo
haiodo force-pushed the fix-product-separation branch 2 times, most recently from 3adc422 to 14a6477 Compare November 16, 2022 05:50
@haiodo
haiodo marked this pull request as ready for review November 16, 2022 06:20
@haiodo
haiodo force-pushed the fix-product-separation branch from 14a6477 to 37ec0be Compare November 16, 2022 09:33
@haiodo
Fix separation by productId
9fcc8e8 
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
@haiodo
haiodo force-pushed the fix-product-separation branch from 37ec0be to 9fcc8e8 Compare November 16, 2022 10:24
@haiodo
haiodo merged commit a8af08d into main Nov 16, 2022
@haiodo
haiodo deleted the fix-product-separation branch November 16, 2022 15:03
mrsadman99 pushed a commit that referenced this pull request Nov 18, 2022
Anton Brechka
Merge branch 'main' into TSK-399
914582f 
* main:
  Allow to create new team (#2375)
  Fix popups (#2384)
  Fix workspace join (#2383)
  Fix separation by productId (#2382)
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
@haiodo
Fix separation by productId (hcengineering#2382)
2ade326 
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BykhovDenis BykhovDenis BykhovDenis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@haiodo @BykhovDenis