Skip to content

Added parameter to remove scroll from Panel content#3865

Merged
lexiv0re merged 1 commit into
mainfrom
panel-content-non-scrollable
Oct 22, 2023
Merged

Added parameter to remove scroll from Panel content#3865
lexiv0re merged 1 commit into
mainfrom
panel-content-non-scrollable

Conversation

@sol-0

@sol-0 sol-0 commented Oct 21, 2023

Copy link
Copy Markdown
Contributor

Contribution checklist

Brief description

Added the case in the Panel when a content scroll is managed by a content component itself (e.g. required for the tab strip to stay in place while tab content is scrolled)

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>
@lexiv0re
lexiv0re merged commit e3e2b02 into main Oct 22, 2023
@lexiv0re
lexiv0re deleted the panel-content-non-scrollable branch October 22, 2023 11:26
{/if}
</div>
{:else if withoutContentScroll}
<div class={contentClasses ?? 'popupPanel-body__main-content py-8 clear-mins'} class:max={useMaxWidth}>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sol-0 you should bind content variable here

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've addressed your comment in the new PR - #3868
Thanks!

MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants